Skip to content

fix: recover workflow lint and template drift - #838

Merged
keito4 merged 1 commit into
mainfrom
audit/repo-recovery-candidates
Jun 17, 2026
Merged

keito4 merged 1 commit into
mainfrom
audit/repo-recovery-candidates

Conversation

@keito4

@keito4 keito4 commented Jun 17, 2026

Copy link
Copy Markdown
Owner

Summary

  • Add actionlint config to suppress only shellcheck info/style noise while preserving actionable workflow lint failures.
  • Make CI run workflow lint when YAML or actionlint config changes.
  • Recover drift between actual workflows, workflow templates, and label templates.
  • Add regression coverage for actionlint config path filtering and PR size labels.

Verification

  • actionlint
  • npm run format:check
  • npm run lint
  • npm test
  • npm run shellcheck
  • npx bats test/integration/workflows.bats
  • npx bats test/integration/
  • bash script/update-agents-md.sh --check
  • git diff --check

Notes

npm audit --audit-level=high currently succeeds, but still reports the existing moderate js-yaml advisory through the Jest dependency tree. This PR does not force the disruptive downgrade suggested by npm audit fix.

@claude

claude Bot commented Jun 17, 2026

Copy link
Copy Markdown
Contributor

Claude finished @keito4's task in 0s —— View job


I'll analyze this and get back to you.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 11ec676910

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment on lines +57 to +58
(github.event_name == 'issue_comment' && contains(github.event.comment.body || '', '@claude') &&
!(github.event.issue.pull_request && github.event.issue.pull_request.url && github.event.issue.draft == true)) ||

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Exclude draft PR issue comments correctly

For issue_comment events on PR conversation comments, github.event.issue is the issue-shaped payload and does not include the PR's draft field, so github.event.issue.draft == true never becomes true. In repositories using this template, commenting @claude on a draft PR still starts the Claude job even though the new header says PR issue comments are excluded for drafts; the workflow needs to fetch the PR or otherwise use a payload that actually contains pull_request.draft before making this decision.

Useful? React with 👍 / 👎.

@keito4 keito4 self-assigned this Jun 17, 2026
@keito4
keito4 merged commit 1c8519b into main Jun 17, 2026
19 checks passed
@keito4
keito4 deleted the audit/repo-recovery-candidates branch June 17, 2026 09:11
@github-actions

Copy link
Copy Markdown
Contributor

🎉 This PR is included in version 1.117.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@github-actions github-actions Bot added the released リリース済み label Jun 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

released リリース済み

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant