Fix global Auto-Type when database locked #3138
Conversation
|
Hi @droidmonkey , I got a build from the branch, and tested. Problem #1216 seems still exists when database is locked
Also, if database is not locked, auto-type window does not get any focus. When i click the entry, immediately auto-type window get closed and does not type anything.
|
|
I cannot fix the main window appearing.... That is a mac "feature". You have to be careful not to click anything after you unlock and (maybe) select an entry. You might have to increase your auto type delay to make sure things settle before typing begins. |
Ok, that is an understandable reason After unlocking the database, auto-type window gets open, but when i select any entry via keyword, does not type anything. I have tested with "Auto-type start delay" -> "1000ms" or "3000ms", and "Auto-type typing delay" with "100ms" nothing changed Also when database is not locked and pressed global auto-type, like i mentioned above; auto-type window does not get focused there for i can not select any entry. |
Wouldn't it be better to just disable the additional popup on macOS? I already tried to hide the main window before but I don't think it is possible at all to do that with Qt on macOS |
|
Disabling the popup would require a big refactor. I'm saving that for 2.5.0 |
droidmonkey
force-pushed
the
hotfix/autotype-mac
branch
from
288f1ad to
6c8eb79
Compare
* Store the currently active window right when the global keyboard shortcut is triggered * Eliminate unnecessary window raise/lower and delays on macOS * Remove duplicate addition of macutils symbols from mac Auto-Type plugin * Fix tests to fake trigger a global autotype sequence
droidmonkey
force-pushed
the
hotfix/autotype-mac
branch
from
6c8eb79 to
cdc51f3
Compare
|
@veysiertekin I see what you mean, once the database was unlocked subsequent presses of the global auto-type shortcut causes the sequence selection dialog to not have focus. I have fixed this issue with the latest push, please try it again. I also lowered the activation delays so it feels a little more responsive. |
|
Hi @droidmonkey, I have tested with your latest changes. Seems focusing problem has been fixed, but after selection of an entry, it goes back the application (in this case my browser), and keepassxc does not type anything like i mentioned above 😞 Not even a single character. (By the way i have build with qt/5.12.3, and tested on macOS 10.14.3) |
|
You probably have to disable/enable the accessibility access for your custom built application. You do that in macOS settings |
|
After addition to accessibility controls, worked as expected! |
- Improve resilience against memory attacks - overwrite memory before free [#3020] - Prevent infinite save loop when location is unavailable [#3026] - Attempt to fix quitting application when shutdown or logout issued [#3199] - Support merging database custom data [#3002] - Fix opening URL's with non-http schemes [#3153] - Fix data loss due to not reading all database attachments if duplicates exist [#3180] - Fix entry context menu disabling when using keyboard navigation [#3199] - Fix behaviors when canceling an entry edit [#3199] - Fix processing of tray icon click and doubleclick [#3112] - Update group in preview widget when focused [#3199] - Prefer DuckDuckGo service over direct icon download (increases resolution) [#2996] - Remove apply button in application settings [#3019] - Use winqtdeploy on Windows to correct deployment issues [#3025] - Don't mark entry edit as modified when attribute selection changes [#3041] - Use console code page CP_UTF8 on Windows if supported [#3050] - Snap: Fix locking database with session lock [#3046] - Snap: Fix theming across Linux distributions [#3057] - Snap: Use SNAP_USER_COMMON and SNAP_USER_DATA directories [#3131] - KeeShare: Automatically enable WITH_XC_KEESHARE_SECURE if quazip is found [#3088] - macOS: Fix toolbar text when in dark mode [#2998] - macOS: Lock database on switching user [#3097] - macOS: Fix global Auto-Type when the database is locked [#3138] - Browser: Close popups when database is locked [#3093] - Browser: Add tests [#3016] - Browser: Don't create default group if custom group is enabled [#3127]
Type of change
Description and Context
Testing strategy
Tested on Windows and macOS
Checklist:
-DWITH_ASAN=ON. [REQUIRED]