Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix apply button not saving new entries #1141

Merged
merged 1 commit into from
Nov 6, 2017
Merged

Fix apply button not saving new entries #1141

merged 1 commit into from
Nov 6, 2017

Conversation

droidmonkey
Copy link
Member

Description

Fixes #1133

Motivation and context

Loss of data if user hits apply then cancel when editing a new entry.

How has this been tested?

Manually and with newly written test cases.

Types of changes

  • ✅ Bug fix (non-breaking change which fixes an issue)

Checklist:

  • ✅ I have read the CONTRIBUTING document. [REQUIRED]
  • ✅ My code follows the code style of this project. [REQUIRED]
  • ✅ All new and existing tests passed. [REQUIRED]
  • ✅ I have compiled and verified my code with -DWITH_ASAN=ON. [REQUIRED]
  • ✅ I have added tests to cover my changes.

@droidmonkey droidmonkey added this to the v2.2.3 milestone Oct 28, 2017
@droidmonkey droidmonkey requested a review from phoerious October 28, 2017 13:26
@TheZ3ro TheZ3ro merged commit 7ef61b4 into release/2.2.3 Nov 6, 2017
@TheZ3ro TheZ3ro deleted the hotfix/apply-button-save branch November 6, 2017 19:29
droidmonkey added a commit that referenced this pull request Dec 12, 2017
@droidmonkey
Release 2.2.3
cf94610 
- Prevent database corruption when locked [#1219]
- Fixes apply button not saving new entries [#1141]
- Switch to Consolas font on Windows for password edit [#1229]
- Multiple fixes to AppImage deployment [#1115, #1228]
- Fixes multiple memory leaks [#1213]
- Resize message close to 16x16 pixels [#1253]
phoerious added a commit that referenced this pull request Dec 13, 2017
@phoerious
Release 2.2.4
4723f66 
- Prevent database corruption when locked [#1219]
- Fixes apply button not saving new entries [#1141]
- Switch to Consolas font on Windows for password edit [#1229]
- Multiple fixes to AppImage deployment [#1115, #1228]
- Fixes multiple memory leaks [#1213]
- Resize message close to 16x16 pixels [#1253]
@phoerious phoerious added pr: bugfix Pull request that fixes a bug and removed bug labels Nov 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phoerious phoerious phoerious approved these changes

@TheZ3ro TheZ3ro TheZ3ro approved these changes

Assignees
No one assigned
Labels
high priority 🚨 pr: bugfix Pull request that fixes a bug
Projects
None yet
Milestone
v2.2.3
Development

Successfully merging this pull request may close these issues.
3 participants
@droidmonkey @TheZ3ro @phoerious