Use Consolas on Windows for PasswordEdit #1229
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
weslly
approved these changes
Nov 26, 2017
droidmonkey
approved these changes
Nov 26, 2017
droidmonkey
added a commit
that referenced
this pull request
Dec 12, 2017
- Prevent database corruption when locked [#1219] - Fixes apply button not saving new entries [#1141] - Switch to Consolas font on Windows for password edit [#1229] - Multiple fixes to AppImage deployment [#1115, #1228] - Fixes multiple memory leaks [#1213] - Resize message close to 16x16 pixels [#1253]
phoerious
added a commit
that referenced
this pull request
Dec 13, 2017
- Prevent database corruption when locked [#1219] - Fixes apply button not saving new entries [#1141] - Switch to Consolas font on Windows for password edit [#1229] - Multiple fixes to AppImage deployment [#1115, #1228] - Fixes multiple memory leaks [#1213] - Resize message close to 16x16 pixels [#1253]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #1226
Description
The default monospace font on Windows is Courier New, which has a few very similar characters. This PR tries to use Consolas instead when KeePassXC is compiled for Windows. Other platforms are unchanged.
Motivation and context
Courier New has very similar characters, e.g. I (lowercase L) and 1, which was a problem for the PasswordEdit field.
How has this been tested?
Compiled on Windows, correct Consolars font is shown.
Types of changes
Checklist:
-DWITH_ASAN=ON. [REQUIRED]