Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use XDG Desktop Portal to autostart the flatpak Fixes #8668 #10563

Merged
merged 1 commit into from
Apr 26, 2024

Conversation

moriol42
Copy link
Contributor

@moriol42 moriol42 commented Apr 8, 2024

When using the KeePassXC flatpak, uses the Background XDG Desktop Portal to create a desktop file automatically in the right location instead of creating one directly in the wrong location. Fixes #8668

TODO:

  • Checking if autostart was enable does not work, and that results in the app thinking autostart is disabled. When the settings are opened the checkbox "Automatically launch KeePassXC at system startup" is unticked and if they are applied without re-ticking the checkbox, the autostart will be disabled. This check was previously done by checking if the desktop file existed, but it does not make sense to do that if we don't create this file ourselves. Should the autostart status be saved in a config file elsewhere instead ?

An empty string is passed instead of the window id of the application since I don't know how to get this id.

Testing strategy

I built and tested the flatpak manually on Fedora 39 on Gnome and KDE, when the "Automatically launch KeePassXC at system startup" checkbox is ticked and the settings are applied, the portal creates the file ~/.config/autostart/org.keepassxc.KeePassXC.desktop:

[Desktop Entry]
Exec=flatpak run org.keepassxc.KeePassXC
Name=org.keepassxc.KeePassXC
Type=Application
X-Flatpak=org.keepassxc.KeePassXC

Type of change

  • ✅ Bug fix (non-breaking change that fixes an issue)

@droidmonkey
Copy link
Member

Neato!

@droidmonkey droidmonkey added this to the v2.7.8 milestone Apr 8, 2024
@moriol42 moriol42 force-pushed the fix/flatpak-autostart branch from 0fe5dbb to c8997f3 Compare April 16, 2024 19:10
@moriol42
Copy link
Contributor Author

I updated my PR to check if the autostart request to the portal was successful and to store the autostart behavior in the config file under the key GUI_LaunchAtStartup. In my testing, the flatpak version now works as intended.

@moriol42 moriol42 force-pushed the fix/flatpak-autostart branch from 26bb65b to 66f0ef5 Compare April 18, 2024 15:58
@moriol42 moriol42 marked this pull request as ready for review April 18, 2024 16:08
@moriol42 moriol42 force-pushed the fix/flatpak-autostart branch from 4b2e569 to 08fe6c3 Compare April 21, 2024 21:07
@droidmonkey droidmonkey merged commit d0e9f13 into keepassxreboot:develop Apr 26, 2024
9 checks passed
@droidmonkey droidmonkey added the pr: backported Pull request backported to previous release label Apr 28, 2024
libf-de pushed a commit to libf-de/keepassxc-secretservice-dbus that referenced this pull request May 6, 2024
Release 2.7.8

Changes
- Add hotkey for showing search help [keepassxreboot#10591]
- Add hotkey for group switching (Ctrl+Shift+PgUp/PgDown) [keepassxreboot#10625]
- Add per-database auto-save delay setting [keepassxreboot#9100]
- Add setting to hide menubar [keepassxreboot#10341]
- Improve Bitwarden 1PUX import and support organization collections [keepassxreboot#10499]
- Show advanced settings checkbox only for settings that have them [keepassxreboot#6513]
- Remove obsolete setting for requiring repeated password entry [keepassxreboot#9722]
- Passkeys: Allow registering Passkeys to existing entries [keepassxreboot#10408]
- Passkeys: Show warning about data being unencrypted before Passkey export [keepassxreboot#10411]
- Passkeys: Support NFC and USB transports [keepassxreboot#10402]
- Passkeys: Pass extension JSON data to browser [keepassxreboot#10615]
- SSH Agent: Do not use entries from recycle bin [keepassxreboot#10518]
- Linux: Change hotkey sequence used for {CLEARFIELD} Auto-Type [keepassxreboot#10008]
- Windows: Improve DACL memory access protection [keepassxreboot#10618]

Fixes
- Fix crash when deleting history items [keepassxreboot#10451]
- Fix crash on screen lock or computer sleep [keepassxreboot#10458]
- Fix search field not being focused after unlock [keepassxreboot#10459]
- Fix loss of window focus when Auto-Type needs to unlock a database [keepassxreboot#10555]
- Fix inconsistent TOTP visibility on unlock [keepassxreboot#10009]
- Fix CSV import skipping over single-name groups [keepassxreboot#10575]
- Fix key file folder being remembered even if disabled in settings [keepassxreboot#10636]
- Fix issues with entry editing and database locking [keepassxreboot#10667]
- Fix key file text when provided on command line [keepassxreboot#10642]
- Fix issues with hardware key auto detection [keepassxreboot#10663]
- Do not override monospace font size [keepassxreboot#10282]
- Perform group sort only when group view is in focus [keepassxreboot#10202]
- Do not show decimals for attachment sizes in Bytes [keepassxreboot#10595]
- Prevent merging of global custom data when merging databases [keepassxreboot#10452]
- Fix minor translation issues [keepassxreboot#10635]
- Passkeys: Fix StrongBox incompatibility [keepassxreboot#10420]
- Passkeys: Set RP ID to effective domain if unset instead of returning an error [keepassxreboot#10384]
- Passkeys: Various UI fixes and improvements [keepassxreboot#10427, keepassxreboot#10608, keepassxreboot#10609]
- AppImage: Fix URL opening [keepassxreboot#10624]
- Flatpak: Fix application autostart [keepassxreboot#10563]
- Linux/macOS: Fix button sizes on modal alert popups [keepassxreboot#10500]
- Linux: Fix clipboard clear on Wayland [keepassxreboot#10500]
- Windows: Preserve file-hidden attribute [keepassxreboot#10343]

# -----BEGIN PGP SIGNATURE-----
#
# iQIzBAABCAAdFiEE6A9nU7OzJX8m9B8ILPQdKqhDj5kFAmY4A30ACgkQLPQdKqhD
# j5npgBAApBCGfhdugBE3X9iCkGQ69LKKWizgp44AzmezxU2ee7KEoZgSmZpOCPyO
# bg9EIgwac+3yCh4i4hJrTvnwIemrUKNsNLE18Kn/Uw3HJBCtsb40CeIFcZktOegu
# RQ5G7jhBtnAopnTKQhdwcwJ0Yq6ZSTSiSuo+miDAN22DjnWVd7BLMOioSBPgxFUT
# td+2MAPeydLoMdFRmkuBaDSStLWThdCz6DrWcBYQSK2b6Mu+3mzmtE24zNM1jCKu
# Tl0t6fRkOhqWSRyWBSMzIH3uMuV95yQNudjDMnuOVWVE9Ai+A1RPFHtf8Zj1ydh9
# n9JGPDyloWRcYQdDBgbn6lFHWnwSaYVCRpRPPmjpmXVwt5/AdtB8wN+6uGbcYTzw
# u9l0YYWx84W0kNPkJ0ZejF33qioQ7FaZruJv2ej++NtO0FJP48UVyrQ4EMG6V+17
# AcQ0aoSWWTb5AYhJXLjImDG7DNY1mbgW6deJLKVS7pkoRke1uSLGqYTUAJCFaXnq
# d9uZt4HRUUMeq6x8dvFNvIcZhsfRUaO/iXjp81nl8hlWIeTYNTj22eww3yapFs+S
# cdmdCmfGZAx5FWCXaszXwD3gLF8Bg6S63l9TvbjEHGR2riYKOO1IbFz8JXXjWpdN
# l4SIcWJfdO2mNz0MWfzNtmMYNu9LBfU2Hod5JHJQYiQh3dh4EG4=
# =MrBi
# -----END PGP SIGNATURE-----
# gpg: directory '/home/runner/.gnupg' created
# gpg: keybox '/home/runner/.gnupg/pubring.kbx' created
# gpg: Signature made Sun May  5 22:09:01 2024 UTC
# gpg:                using RSA key E80F6753B3B3257F26F41F082CF41D2AA8438F99
# gpg: Can't check signature: No public key
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
distribution: Flatpak pr: backported Pull request backported to previous release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

flatpak: Enabling autolaunch does not work
2 participants