Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Passkeys: Fix duplicate database selection #10609

Merged
merged 1 commit into from
Apr 21, 2024
Merged

Passkeys: Fix duplicate database selection #10609

merged 1 commit into from
Apr 21, 2024

Conversation

varjolintu
Copy link
Member

@varjolintu varjolintu commented Apr 21, 2024 •
edited
Loading

Database selection is asked twice when registering new credentials when multiple databases are open, once in showPasskeysRegisterPrompt() and second time in addPasskeyToGroup(). Third time happens in showPasskeysAuthenticationPrompt() which is not necessary. Passkey entries are already returned from all connected databases.

Fixes #10602

Testing strategy

  • Open two databases, both connected.
  • Register a new passkey -> two database selection dialogs are shown
  • Authenticate it right away -> database selection dialog is shown again

Type of change

  • ✅ Bug fix (non-breaking change that fixes an issue)

@varjolintu varjolintu added this to the v2.7.8 milestone Apr 21, 2024
@varjolintu varjolintu requested a review from droidmonkey April 21, 2024 06:01
@varjolintu varjolintu force-pushed the fix/passkeys_fix_duplicate_database_selection branch from d5ce6c9 to 7e15209 Compare April 21, 2024 07:29
@droidmonkey droidmonkey merged commit 41d0013 into keepassxreboot:develop Apr 21, 2024
9 checks passed
@varjolintu varjolintu deleted the fix/passkeys_fix_duplicate_database_selection branch April 21, 2024 11:32
@droidmonkey droidmonkey added the pr: backported Pull request backported to previous release label Apr 28, 2024
@sahriVoraus
Copy link

sahriVoraus commented May 3, 2024 •
edited
Loading

@droidmonkey I tried this fix with the latest snapshot build-245433. In general the behavior is expected but there is still one edge case.
Let's say I have Database1 and Database2. Database1 has a passkey for website XY.
Now I want to add second passkey for the same website to Database2. On the dialogue to select which database to store it, I select Database2. Nevertheless I get the Dialogue saying "Existing Passkey found". When I press Update it is updated in Database1 even though I selected Database2.

I don't know if this might even be desired behavior because it may remind you that there is already a passkey in the other database.

Edit: this only happens if it is the same user.

@droidmonkey
Copy link
Member

Seems like an extreme edge case, but the sequence is confusing since you are trying to select database 2.

libf-de pushed a commit to libf-de/keepassxc-secretservice-dbus that referenced this pull request May 6, 2024
@release-bot
Merge tag 'tags/2.7.8' into proposed-2.7.8
8c51861 
Release 2.7.8

Changes
- Add hotkey for showing search help [keepassxreboot#10591]
- Add hotkey for group switching (Ctrl+Shift+PgUp/PgDown) [keepassxreboot#10625]
- Add per-database auto-save delay setting [keepassxreboot#9100]
- Add setting to hide menubar [keepassxreboot#10341]
- Improve Bitwarden 1PUX import and support organization collections [keepassxreboot#10499]
- Show advanced settings checkbox only for settings that have them [keepassxreboot#6513]
- Remove obsolete setting for requiring repeated password entry [keepassxreboot#9722]
- Passkeys: Allow registering Passkeys to existing entries [keepassxreboot#10408]
- Passkeys: Show warning about data being unencrypted before Passkey export [keepassxreboot#10411]
- Passkeys: Support NFC and USB transports [keepassxreboot#10402]
- Passkeys: Pass extension JSON data to browser [keepassxreboot#10615]
- SSH Agent: Do not use entries from recycle bin [keepassxreboot#10518]
- Linux: Change hotkey sequence used for {CLEARFIELD} Auto-Type [keepassxreboot#10008]
- Windows: Improve DACL memory access protection [keepassxreboot#10618]

Fixes
- Fix crash when deleting history items [keepassxreboot#10451]
- Fix crash on screen lock or computer sleep [keepassxreboot#10458]
- Fix search field not being focused after unlock [keepassxreboot#10459]
- Fix loss of window focus when Auto-Type needs to unlock a database [keepassxreboot#10555]
- Fix inconsistent TOTP visibility on unlock [keepassxreboot#10009]
- Fix CSV import skipping over single-name groups [keepassxreboot#10575]
- Fix key file folder being remembered even if disabled in settings [keepassxreboot#10636]
- Fix issues with entry editing and database locking [keepassxreboot#10667]
- Fix key file text when provided on command line [keepassxreboot#10642]
- Fix issues with hardware key auto detection [keepassxreboot#10663]
- Do not override monospace font size [keepassxreboot#10282]
- Perform group sort only when group view is in focus [keepassxreboot#10202]
- Do not show decimals for attachment sizes in Bytes [keepassxreboot#10595]
- Prevent merging of global custom data when merging databases [keepassxreboot#10452]
- Fix minor translation issues [keepassxreboot#10635]
- Passkeys: Fix StrongBox incompatibility [keepassxreboot#10420]
- Passkeys: Set RP ID to effective domain if unset instead of returning an error [keepassxreboot#10384]
- Passkeys: Various UI fixes and improvements [keepassxreboot#10427, keepassxreboot#10608, keepassxreboot#10609]
- AppImage: Fix URL opening [keepassxreboot#10624]
- Flatpak: Fix application autostart [keepassxreboot#10563]
- Linux/macOS: Fix button sizes on modal alert popups [keepassxreboot#10500]
- Linux: Fix clipboard clear on Wayland [keepassxreboot#10500]
- Windows: Preserve file-hidden attribute [keepassxreboot#10343]

# -----BEGIN PGP SIGNATURE-----
#
# iQIzBAABCAAdFiEE6A9nU7OzJX8m9B8ILPQdKqhDj5kFAmY4A30ACgkQLPQdKqhD
# j5npgBAApBCGfhdugBE3X9iCkGQ69LKKWizgp44AzmezxU2ee7KEoZgSmZpOCPyO
# bg9EIgwac+3yCh4i4hJrTvnwIemrUKNsNLE18Kn/Uw3HJBCtsb40CeIFcZktOegu
# RQ5G7jhBtnAopnTKQhdwcwJ0Yq6ZSTSiSuo+miDAN22DjnWVd7BLMOioSBPgxFUT
# td+2MAPeydLoMdFRmkuBaDSStLWThdCz6DrWcBYQSK2b6Mu+3mzmtE24zNM1jCKu
# Tl0t6fRkOhqWSRyWBSMzIH3uMuV95yQNudjDMnuOVWVE9Ai+A1RPFHtf8Zj1ydh9
# n9JGPDyloWRcYQdDBgbn6lFHWnwSaYVCRpRPPmjpmXVwt5/AdtB8wN+6uGbcYTzw
# u9l0YYWx84W0kNPkJ0ZejF33qioQ7FaZruJv2ej++NtO0FJP48UVyrQ4EMG6V+17
# AcQ0aoSWWTb5AYhJXLjImDG7DNY1mbgW6deJLKVS7pkoRke1uSLGqYTUAJCFaXnq
# d9uZt4HRUUMeq6x8dvFNvIcZhsfRUaO/iXjp81nl8hlWIeTYNTj22eww3yapFs+S
# cdmdCmfGZAx5FWCXaszXwD3gLF8Bg6S63l9TvbjEHGR2riYKOO1IbFz8JXXjWpdN
# l4SIcWJfdO2mNz0MWfzNtmMYNu9LBfU2Hod5JHJQYiQh3dh4EG4=
# =MrBi
# -----END PGP SIGNATURE-----
# gpg: directory '/home/runner/.gnupg' created
# gpg: keybox '/home/runner/.gnupg/pubring.kbx' created
# gpg: Signature made Sun May  5 22:09:01 2024 UTC
# gpg:                using RSA key E80F6753B3B3257F26F41F082CF41D2AA8438F99
# gpg: Can't check signature: No public key
@phoerious phoerious added pr: bugfix Pull request that fixes a bug and removed bug labels Nov 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@droidmonkey droidmonkey droidmonkey approved these changes

Assignees
No one assigned
Labels
feature: Passkeys pr: backported Pull request backported to previous release pr: bugfix Pull request that fixes a bug
Projects
None yet
Milestone
v2.7.8
Development

Successfully merging this pull request may close these issues.

[BUG] When having mutliple Databases opened KeepassXC asks twice in which one a new Passkey shall be stored
4 participants
@varjolintu @sahriVoraus @droidmonkey @phoerious