Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auto-Type key modifiers not implemented #2603

Closed
dotancohen opened this issue Jan 15, 2019 · 5 comments · Fixed by #5864
Closed

Auto-Type key modifiers not implemented #2603

dotancohen opened this issue Jan 15, 2019 · 5 comments · Fixed by #5864
Assignees
Milestone

Comments

@dotancohen
Copy link

dotancohen commented Jan 15, 2019

Expected Behavior

The string %d in the Autocomplete field should send Alt-D to the application.

Current Behavior

The string %d in the Autocomplete field is sending d to the application.

Steps to Reproduce

  1. Replace the Autocomplete field for a website with %d.
  2. Invoke autocompletion.
  3. I expect the URL field to be focused, but instead a literal d was sent to the page.

Context

Using Firefox 64.0 on Ubuntu Linux 18.10 with KDE 5 and KeepassXC 2.3.1 with no extensions.

@dotancohen
Copy link
Author

The feature of % sending ALT is documented here:
https://keepass.info/%0D/help/base/autotype.html

@droidmonkey
Copy link
Member

I am not in favor of that syntax at all. Bare words should never be interpreted as special actions. If anything it should be reversed... {%d} should execute ALT+D.

@dotancohen
Copy link
Author

@droidmonkey I happen to agree with you, and I personally would prefer {%d} to %d. However, the keepass "spec" is that document and multiple implementations already conform to that spec.

@droidmonkey droidmonkey changed the title Modifier sequences do not work (Possibly platform-related) Auto-Type key modifiers not implemented Aug 22, 2020
@droidmonkey droidmonkey self-assigned this Aug 22, 2020
@droidmonkey droidmonkey added this to the v2.7.0 milestone Aug 22, 2020
@mara004
Copy link

mara004 commented Aug 30, 2020

Possibly, a note that key modifiers don't work should be added somwhere in the documentation until they are implemented? Currently, the docs states by mistake that all keys mentioned on the KeePass website would be supported (Quote: "A complete list of supported actions and placeholders can be found at KeePass Auto-Type Action Codes and KeePass Placeholders.")

I do agree with @dotancohen that KeePassXC should use the same notation as KeePass for this functionality (regardless of whether we personally like the syntax), so that people switching from KeePass can easily copy/paste their autotype sequences and do not have to learn two different notations. It would also make documentation easier if autotype was implemented in exactly the same way as in KeePass, then we could keep refering to to its autotype key list.

@droidmonkey
Copy link
Member

I'm just going to implement it

droidmonkey added a commit that referenced this issue Dec 2, 2020
* Close #2603 - Add support for modifier syntax (+, ^, and %)
* Fix #2633 - Allow reference syntax {REF:...} in Auto-Type sequences
droidmonkey added a commit that referenced this issue Dec 3, 2020
* Close #2603 - Add support for modifier syntax (+, ^, and %)
* Fix #2633 - Allow reference syntax {REF:...} in Auto-Type sequences
droidmonkey added a commit that referenced this issue Dec 3, 2020
* Close #2603 - Add support for modifier syntax (+, ^, and %)
* Fix #2633 - Allow reference syntax {REF:...} in Auto-Type sequences
* Close #5334  - Tell the user which part of the Auto-Type sequence is invalid for easy correction
* Fix #2401 - Select the right window on macOS prior to starting Auto-Type

* Allow for nested placeholders
droidmonkey added a commit that referenced this issue Dec 17, 2020
* Close #2603 - Add support for modifier syntax (+, ^, and %)
* Fix #2633 - Allow reference syntax {REF:...} in Auto-Type sequences
* Close #5334  - Tell the user which part of the Auto-Type sequence is invalid for easy correction
* Fix #2401 - Select the right window on macOS prior to starting Auto-Type

* Allow for nested placeholders
droidmonkey added a commit that referenced this issue Dec 24, 2020
* Close #2603 - Add support for modifier syntax (+, ^, and %)
* Fix #2633 - Allow reference syntax {REF:...} in Auto-Type sequences
* Close #5334  - Tell the user which part of the Auto-Type sequence is invalid for easy correction
* Fix #2401 - Select the right window on macOS prior to starting Auto-Type

* Allow for nested placeholders
droidmonkey added a commit that referenced this issue Dec 26, 2020
* Close #2603 - Add support for modifier syntax (+, ^, and %)
* Fix #2633 - Allow reference syntax {REF:...} in Auto-Type sequences
* Close #5334  - Tell the user which part of the Auto-Type sequence is invalid for easy correction
* Fix #2401 - Select the right window on macOS prior to starting Auto-Type

* Allow for nested placeholders
droidmonkey added a commit that referenced this issue Feb 14, 2021
* Close #2603 - Add support for modifier syntax (+, ^, and %)
* Fix #2633 - Allow reference syntax {REF:...} in Auto-Type sequences
* Close #5334  - Tell the user which part of the Auto-Type sequence is invalid for easy correction
* Fix #2401 - Select the right window on macOS prior to starting Auto-Type

* Allow for nested placeholders
droidmonkey added a commit that referenced this issue Feb 15, 2021
* Close #2603 - Add support for modifier syntax (+, ^, and %)
* Fix #2633 - Allow reference syntax {REF:...} in Auto-Type sequences
* Close #5334  - Tell the user which part of the Auto-Type sequence is invalid for easy correction
* Fix #2401 - Select the right window on macOS prior to starting Auto-Type

* Allow for nested placeholders
droidmonkey added a commit that referenced this issue Feb 22, 2021
* Close #2603 - Add support for modifier syntax (+, ^, and %)
* Fix #2633 - Allow reference syntax {REF:...} in Auto-Type sequences
* Close #5334  - Tell the user which part of the Auto-Type sequence is invalid for easy correction
* Fix #2401 - Select the right window on macOS prior to starting Auto-Type

* Allow for nested placeholders
libklein pushed a commit to libklein/keepassxc that referenced this issue Mar 1, 2021
* Close keepassxreboot#2603 - Add support for modifier syntax (+, ^, and %)
* Fix keepassxreboot#2633 - Allow reference syntax {REF:...} in Auto-Type sequences
* Close keepassxreboot#5334  - Tell the user which part of the Auto-Type sequence is invalid for easy correction
* Fix keepassxreboot#2401 - Select the right window on macOS prior to starting Auto-Type

* Allow for nested placeholders
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants