Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Autotype picks the wrong window in multi-monitor setup [MacOS] #2401

Closed
dovecode opened this issue Oct 19, 2018 · 5 comments · Fixed by #5864
Closed

Autotype picks the wrong window in multi-monitor setup [MacOS] #2401

dovecode opened this issue Oct 19, 2018 · 5 comments · Fixed by #5864
Assignees
@droidmonkey
Labels
feature: Auto-Type platform: macOS
Milestone
v2.7.0

Comments

@dovecode
Copy link

dovecode commented Oct 19, 2018 •
edited by droidmonkey
Loading

Expected Behavior

When pressing the global hotkey for autotype, the user name and password should be entered into the application window that the user had focus on.

Current Behavior

KeepassXC sometimes picks the wrong window of the application. This seems to happen when there are multiple windows of the same application (e.g. browser windows) open on different monitors.

Possible Solution

No idea. This is probably related to MacOS "alternative" window switching behavior.

Steps to Reproduce (for bugs)

  1. Configure multi-monitor setup
  2. Open an application that support multiple windows (e.g. Firefox)
  3. Place a window on every monitor
  4. Press the global autotype hotkey
    (step 4 might be tried in different windows on different monitors -- I have yet to find a pattern)

Context

This ends up with passwords in URLs, submitted in forms, etc. The information leakage is pretty bad!

Debug Info

KeePassXC - Version 2.3.4
Revision: 6fe821c

Libraries:

  • Qt 5.9.3
  • libgcrypt 1.8.2

Operating system: macOS 10.14
CPU architecture: x86_64
Kernel: darwin 18.0.0

Enabled extensions:

  • Auto-Type
  • Browser Integration
  • Legacy Browser Integration (KeePassHTTP)
  • SSH Agent
  • YubiKey
@phoerious
Copy link
Member

Auto-Type needs some fixes in general. Unlocking from Auto-Type when there is another database open also focuses back the KeePassXC window.

@stefansundin stefansundin mentioned this issue Mar 11, 2020
Closed
@jazzschmidt
Copy link

In my case, when using Auto-Type via hotkey, the main window is focused instead of the Auto-Type list. This happens for applications, that have or had multiple windows even on the same desktop. Moving the main window to that desktop Auto-Type works most of the time.

@droidmonkey droidmonkey added this to the v2.7.0 milestone Aug 31, 2020
@droidmonkey droidmonkey self-assigned this Aug 31, 2020
@droidmonkey
Copy link
Member

Adding this to my Auto-Type overhaul for 2.7.0

droidmonkey added a commit that referenced this issue Dec 3, 2020
@droidmonkey
Overhaul Auto-Type Action Handling
164de4d 
* Close #2603 - Add support for modifier syntax (+, ^, and %)
* Fix #2633 - Allow reference syntax {REF:...} in Auto-Type sequences
* Close #5334  - Tell the user which part of the Auto-Type sequence is invalid for easy correction
* Fix #2401 - Select the right window on macOS prior to starting Auto-Type

* Allow for nested placeholders
droidmonkey added a commit that referenced this issue Dec 17, 2020
@droidmonkey
Overhaul Auto-Type Action Handling
2d894b9 
* Close #2603 - Add support for modifier syntax (+, ^, and %)
* Fix #2633 - Allow reference syntax {REF:...} in Auto-Type sequences
* Close #5334  - Tell the user which part of the Auto-Type sequence is invalid for easy correction
* Fix #2401 - Select the right window on macOS prior to starting Auto-Type

* Allow for nested placeholders
droidmonkey added a commit that referenced this issue Dec 24, 2020
@droidmonkey
Overhaul Auto-Type Action Handling
445bbae 
* Close #2603 - Add support for modifier syntax (+, ^, and %)
* Fix #2633 - Allow reference syntax {REF:...} in Auto-Type sequences
* Close #5334  - Tell the user which part of the Auto-Type sequence is invalid for easy correction
* Fix #2401 - Select the right window on macOS prior to starting Auto-Type

* Allow for nested placeholders
@droidmonkey droidmonkey mentioned this issue Dec 24, 2020
Merged
2 tasks
droidmonkey added a commit that referenced this issue Dec 26, 2020
@droidmonkey
Overhaul Auto-Type Action Handling
0268826 
* Close #2603 - Add support for modifier syntax (+, ^, and %)
* Fix #2633 - Allow reference syntax {REF:...} in Auto-Type sequences
* Close #5334  - Tell the user which part of the Auto-Type sequence is invalid for easy correction
* Fix #2401 - Select the right window on macOS prior to starting Auto-Type

* Allow for nested placeholders
droidmonkey added a commit that referenced this issue Feb 14, 2021
@droidmonkey
Overhaul Auto-Type Action Handling
dfb0df8 
* Close #2603 - Add support for modifier syntax (+, ^, and %)
* Fix #2633 - Allow reference syntax {REF:...} in Auto-Type sequences
* Close #5334  - Tell the user which part of the Auto-Type sequence is invalid for easy correction
* Fix #2401 - Select the right window on macOS prior to starting Auto-Type

* Allow for nested placeholders
droidmonkey added a commit that referenced this issue Feb 15, 2021
@droidmonkey
Overhaul Auto-Type Action Handling
283e473 
* Close #2603 - Add support for modifier syntax (+, ^, and %)
* Fix #2633 - Allow reference syntax {REF:...} in Auto-Type sequences
* Close #5334  - Tell the user which part of the Auto-Type sequence is invalid for easy correction
* Fix #2401 - Select the right window on macOS prior to starting Auto-Type

* Allow for nested placeholders
droidmonkey added a commit that referenced this issue Feb 22, 2021
@droidmonkey
Overhaul Auto-Type Action Handling
027ff9f 
* Close #2603 - Add support for modifier syntax (+, ^, and %)
* Fix #2633 - Allow reference syntax {REF:...} in Auto-Type sequences
* Close #5334  - Tell the user which part of the Auto-Type sequence is invalid for easy correction
* Fix #2401 - Select the right window on macOS prior to starting Auto-Type

* Allow for nested placeholders
libklein pushed a commit to libklein/keepassxc that referenced this issue Mar 1, 2021
@droidmonkey @libklein
Overhaul Auto-Type Action Handling
215de6d 
* Close keepassxreboot#2603 - Add support for modifier syntax (+, ^, and %)
* Fix keepassxreboot#2633 - Allow reference syntax {REF:...} in Auto-Type sequences
* Close keepassxreboot#5334  - Tell the user which part of the Auto-Type sequence is invalid for easy correction
* Fix keepassxreboot#2401 - Select the right window on macOS prior to starting Auto-Type

* Allow for nested placeholders
@Pointy
Copy link

Pointy commented Apr 5, 2022

Still happening for me with 2.7.0. I have two Safari windows open, one on the same monitor as KeePassXC (where I want the auto-type to take effect), and one on a different monitor. Performing autotype in this situation seems to always, or almost always, type into the Safari window in the other (not primary) monitor. I've got my Mission Control set up such that the primary monitor (the one where I want the action to work) has a few (like 4 or 5) desktops, and the other monitor has 1 or 2.

I'm on a basically brand new MacBook, fully updated.

@mrkeuz
Copy link

mrkeuz commented Jun 27, 2022 •
edited
Loading

Faced with quite same issue on Linux.

When database LOCKED and you try Auto-Type from global shortcut - dialog appears on latest position (i.e. on other screen). Very uncomfortable.

Need another issue for this?

Env:
KeePassXC 2.7.1 (snap)
Ubuntu 20.04 (x11, gnome)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@droidmonkey droidmonkey

Labels
feature: Auto-Type platform: macOS
Projects
None yet
Milestone
v2.7.0
Development

Successfully merging a pull request may close this issue.

Major improvements to Auto-Type keepassxreboot/keepassxc
6 participants
@Pointy @phoerious @droidmonkey @jazzschmidt @mrkeuz @dovecode