-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add redis streams length e2e test images (#4277) #117
Conversation
Signed-off-by: jmadajczak <[email protected]>
Hi, |
Hey, current images (for cluster and sentinel) reads messages and acks on them, but do not removes messages from the stream, it works as an append only stream. Provided images pops out readen messages, so the stream length decreases |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
I am curious wouldn't it make a sense to modify existing images and sources? ie. add some parameter to enable/disable this feature?
This might be easier to maintain for us.
I think it's possible to extend redis cluster and sentinel images, but standalone is outside of the repository. It might be easier to rewrite standalone image/test, shall I do this? |
I think that if this is something we can parametrize, we could parametrize it and also adding the code for standalone redis. I mean, you have already added the code with the new feature, you could just replace the already existing external image using your code with the flag |
Signed-off-by: jmadajczak <[email protected]>
I've made one image handling all redis-streams test cases, "one to rule them all" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Thanks for the improvement
Images added for testing issue kedacore/keda#4277
Checklist
Fixes #