feat: Allow scaling using redis stream length (#4277) #4390
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jkbmdk
force-pushed
the
redis-streams-length
branch
from
07f7ba3
to
ef6d073
Compare
Signed-off-by: jmadajczak <[email protected]>
jkbmdk
force-pushed
the
redis-streams-length
branch
from
ef6d073
to
b41fbf2
Compare
JorTurFer
reviewed
Mar 20, 2023
Signed-off-by: jmadajczak <[email protected]>
![semgrep-app[bot]](https://avatars.githubusercontent.com/in/60555?s=60&v=4){kind=small}
jkbmdk
force-pushed
the
redis-streams-length
branch
from
51acdb0
to
436f93b
Compare
Signed-off-by: jmadajczak <[email protected]>
jkbmdk
force-pushed
the
redis-streams-length
branch
from
436f93b
to
3d2d358
Compare
|
/run-e2e redis* |
Signed-off-by: jmadajczak <[email protected]>
Co-authored-by: Jorge Turrado Ferrero <[email protected]> Signed-off-by: jkbmdk <[email protected]>
|
Hey @JorTurFer , is there anything else I can do to help introduce that feature? |
|
/run-e2e redis* |
I think that only the conflict is changelog is left here |
1 task
Signed-off-by: Jakub Madajczak <[email protected]>
|
/run-e2e redis* |
JorTurFer
approved these changes
Mar 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make the redis stream scaler optionally dependent on the XLEN parameter
Checklist
Relates to #4277
Relates to kedacore/test-tools#117
Relates to kedacore/keda-docs#1094