Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for aws secret manager authentication #4739

Closed
wants to merge 2 commits into from

Conversation

nitishchauhan0022
Copy link
Contributor

Added the Support for TriggerAuthentication using aws secret manager

Checklist

Relates to #4628

Signed-off-by: ntishchauhan0022 <[email protected]>
Signed-off-by: ntishchauhan0022 <[email protected]>
@nitishchauhan0022 nitishchauhan0022 requested a review from a team as a code owner June 26, 2023 16:00
@github-actions
Copy link

Thank you for your contribution! 🙏 We will review your PR as soon as possible.

While you are waiting, make sure to:

Learn more about:

@semgrep-app
Copy link

semgrep-app bot commented Jun 26, 2023

Semgrep found 6 wrong-wrapped-error findings:

Semgrep found a possible error wrong wrapped.

Ignore this finding from wrong-wrapped-error.

@JorTurFer
Copy link
Member

Looking good! ❤️
Could you rebase the main branch (there are some merge conflicts) and also add some e2e test for this feature? We already have some e2e tests for Azure Key Vault that you could use as example: https://github.com/kedacore/keda/tree/main/tests/secret-providers
In order to have the KMS, you need to create it through the testing-infrastructure repo (we can help you with that if you want)
Also, this feature requires changes in docs explaining it 🙏

@JorTurFer
Copy link
Member

Any update? We aim to cut a release next week

@nitishchauhan0022
Copy link
Contributor Author

I am really occupied by other things. I don't have plans to do this in coming week.

@zroubalik
Copy link
Member

Replaced by #5162

@zroubalik zroubalik closed this Dec 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants