Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Authentication: support AWS secret manager #4628

Closed
Tracked by #5275
devopsmash opened this issue Jun 1, 2023 · 4 comments · Fixed by #5162
Closed
Tracked by #5275

Authentication: support AWS secret manager #4628

devopsmash opened this issue Jun 1, 2023 · 4 comments · Fixed by #5162
Assignees
@geoffrey1330
Labels
aws All issues concerning integration with AWS feature All issues for new features that have been committed to help wanted Looking for support from community

Comments

@devopsmash
Copy link

devopsmash commented Jun 1, 2023 •
edited
Loading

Proposal

add to TriggerAuthentication support to "AWS secret manager"

Use-Case

We are using AWS MSK with sasl (user & password) for authentication

Why? Because we are allowing our Dev team in Development environment to access the MSK with public IP.
Therefor, the developer can't use AWS IAM role (we are not providing them aws creds) so we have to use sasl (user & password).

Because of this, we want that TriggerAuthentication will support also getting the user & password from the AWS secret manager instead of a k8s secret that realy easy to get the creds.

Is this a feature you are interested in implementing yourself?

No

Anything else?

It seems that you already support Hashicorp Vault secret(s) and Azure Key Vault secret(s).
Support AWS secret manager can be very helpful.

more here: https://keda.sh/docs/2.10/concepts/authentication/
@devopsmash devopsmash added feature-request All issues for new features that have not been committed to needs-discussion labels Jun 1, 2023
@JorTurFer JorTurFer added help wanted Looking for support from community feature All issues for new features that have been committed to aws All issues concerning integration with AWS and removed needs-discussion feature-request All issues for new features that have not been committed to labels Jun 2, 2023
@nitishchauhan0022
Copy link
Contributor

I would like to work on it, could you please assign this to me @JorTurFer

@JorTurFer
Copy link
Member

Nice!!! ❤️❤️❤️

@nitishchauhan0022 nitishchauhan0022 mentioned this issue Jun 26, 2023
Closed
7 tasks
@geoffrey1330
Copy link
Contributor

Hi @zroubalik could you please assign this task to me as it been stale for a while now.
cc @JorTurFer

@JorTurFer
Copy link
Member

Sure !
❤️

@geoffrey1330 geoffrey1330 mentioned this issue Nov 7, 2023
Merged
7 tasks
@JorTurFer JorTurFer mentioned this issue Dec 11, 2023
Closed
25 tasks
@wozniakjan wozniakjan mentioned this issue Jan 10, 2024
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@geoffrey1330 geoffrey1330

Labels
aws All issues concerning integration with AWS feature All issues for new features that have been committed to help wanted Looking for support from community
Projects
Roadmap - KEDA Core
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add support aws secretmanager authentication geoffrey1330/keda
4 participants
@devopsmash @JorTurFer @geoffrey1330 @nitishchauhan0022