Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

validate triggers also in the webhook #4670

Merged
merged 1 commit into from
Jun 18, 2023
Merged

validate triggers also in the webhook #4670

merged 1 commit into from
Jun 18, 2023

Conversation

zroubalik
Copy link
Member

@zroubalik zroubalik commented Jun 9, 2023 •
edited
Loading

Also moving ScaleTriggers to a separate file, because it is used both by ScaledObject and ScaledJob types.

Checklist

  • Tests have been added
  • Changelog has been updated and is aligned with our changelog requirements
  • Commits are signed with Developer Certificate of Origin (DCO - learn more)

Fixes #4664

@zroubalik zroubalik requested a review from a team as a code owner June 9, 2023 11:25
@zroubalik
Copy link
Member Author

zroubalik commented Jun 9, 2023 •
edited by github-actions bot
Loading

/run-e2e internal
Update: You can check the progress here

@zroubalik
Copy link
Member Author

zroubalik commented Jun 9, 2023 •
edited by github-actions bot
Loading

/run-e2e internal
Update: You can check the progress here

@zroubalik
Copy link
Member Author

zroubalik commented Jun 18, 2023 •
edited by github-actions bot
Loading

/run-e2e
Update: You can check the progress here

@zroubalik zroubalik enabled auto-merge (squash) June 18, 2023 14:36
@zroubalik zroubalik requested a review from JorTurFer June 18, 2023 14:37
@zroubalik
Copy link
Member Author

/run-e2e Update: You can check the progress here

@JorTurFer do you know if there's anything broken in following test in general?

Execution of tests/scalers/azure/azure_pipelines/azure_pipelines_test.go, has failed after "three" attempts
2023-06-18T15:54:03.0800698Z make: *** [Makefile:***08: e***e-test] Error ***

@JorTurFer
Copy link
Member

JorTurFer commented Jun 18, 2023 •
edited by github-actions bot
Loading

/run-e2e
Update: You can check the progress here

@zroubalik zroubalik merged commit 0e7662d into kedacore:main Jun 18, 2023
SpiritZhou pushed a commit to SpiritZhou/keda that referenced this pull request Jun 30, 2023
@zroubalik @SpiritZhou
validate triggers also in the webhook (kedacore#4670)
293998d 
Signed-off-by: Zbynek Roubalik <[email protected]>
@radekfojtik radekfojtik mentioned this pull request Oct 26, 2023
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JorTurFer JorTurFer JorTurFer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ScaledObject with multiple triggers with non unique name should be rejected at creation
2 participants
@zroubalik @JorTurFer