Merge branch 'main' into validT

kedacore · Jun 9, 2023 · 552aac6 · 552aac6
2 parents 57740ed + 190c6e0
commit 552aac6
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 1 deletion.
diff --git a/.github/workflows/pr-welcome.yml b/.github/workflows/pr-welcome.yml
@@ -7,6 +7,7 @@ on:
     - 'main'
 
 permissions:
+  issues: write
   pull-requests: write
 
 jobs:

diff --git a/pkg/scaling/scale_handler.go b/pkg/scaling/scale_handler.go
@@ -396,7 +396,6 @@ func (h *scaleHandler) ClearScalersCache(ctx context.Context, scalableObject int
 /// --------------------------------------------------------------------------- ///
 
 // GetScaledObjectMetrics returns metrics for specified metric name for a ScaledObject identified by it's name and namespace.
-// The second return value are Prometheus metrics that needed to be exposed (used by DEPRECATED Prometheus Server on KEDA Metrics Server)
 // It could either query the metric value directly from the scaler or from a cache, that's being stored for the scaler.
 func (h *scaleHandler) GetScaledObjectMetrics(ctx context.Context, scaledObjectName, scaledObjectNamespace, metricName string) (*external_metrics.ExternalMetricValueList, error) {
 	logger := log.WithValues("scaledObject.Namespace", scaledObjectNamespace, "scaledObject.Name", scaledObjectName)