fix: respect all required demands in azure pipeline scaler

[EugeneLugovtsov]

Fix issue with Azure Pipelines Scaler. When Azure DevOps does not provide Agent.Version keda may scale a wrong agent.

Checklist

• When introducing a new scaler, I agree with the scaling governance policy
• I have verified that my change is according to the deprecations & breaking changes policy
• Tests have been added
• Changelog has been updated and is aligned with our changelog requirements
• A PR is opened to update our Helm chart (repo) (if applicable, ie. when deployment manifests are modified)
• A PR is opened to update the documentation on (repo) (if applicable)
• Commits are signed with Developer Certificate of Origin (DCO - learn more)

Fixes #
#4404
Relates to #

[EugeneLugovtsov]

@zroubalik may I ask you to review this PR?

[JorTurFer]

@Eldarrin, could you take a look?

[Eldarrin]

Can you replace the function with this and resubmit, may fix the issue.

`
func stripAgentVFromArray(array []string) []string {
var result []string
for _, item := range array {
if !strings.HasPrefix(item, "Agent.Version") {
result = append(result, item)
}
}
return result
}

func getCanAgentDemandFulfilJob(jr JobRequest, metadata *azurePipelinesMetadata) bool {
countDemands := 0
demandsInJob := stripAgentVFromArray(jr.Demands)
demandsInScaler := stripAgentVFromArray(strings.Split(metadata.demands, ","))
for _, demandInJob := range demandsInJob {
for _, demandInScaler := range demandsInScaler {
if demandInJob == demandInScaler {
countDemands++
}
}
}
if metadata.requireAllDemands {
return countDemands == len(demandsInJob) && countDemands == len(demandsInScaler)
} else {
return countDemands == len(demandsInJob)
}
}`

[EugeneLugovtsov]

@Eldarrin thanks for your help. I updated PR

[EugeneLugovtsov]

@Eldarrin could you please help with it?

[Eldarrin]

@Eldarrin could you please help with it?

HI @EugeneLugovtsov I can't see anything wrong with it, @JorTurFer is there some sort of idiomatic thing I'm missing or is it possible to //nolint this?

[zroubalik]

@Eldarrin could you please help with it?

HI @EugeneLugovtsov I can't see anything wrong with it, @JorTurFer is there some sort of idiomatic thing I'm missing or is it possible to //nolint this?

What is potentially suspicious is, that we are comparing the same property countDemands against different 2 properties but these should have the same value, because we have AND there. If this is really what we want to have, then we should add exception to https://github.com/kedacore/keda/blob/main/.golangci.yml

[EugeneLugovtsov]

@zroubalik yep, we want to be sure, that countDemands, len(demandsInJob), and len(demandsInScaler) are the same.

[zroubalik]

/run-e2e azure*
Update: You can check the progress here

[Eldarrin]

/run-e2e azure* Update: You can check the progress here

@zroubalik can you do the e2e with pipelines, not the whole of azure? looks like those are failing.

Cheers :)

[JorTurFer]

/run-e2e pipeline*
Update: You can check the progress here

[JorTurFer]

Yeah, Azure test are failing because this commit is required

[EugeneLugovtsov]

@JorTurFer @Eldarrin do I need to do something? do I need to add this commit ?

[Eldarrin]

@JorTurFer @Eldarrin do I need to do something? do I need to add this commit ?

Think you just need to complete the task list by checking the boxes at the top.

[EugeneLugovtsov]

@JorTurFer @Eldarrin could you help with the next steps? what do we need to do?

[Eldarrin]

Approved from my end, all looks good

[JorTurFer]

LGTM! Thanks for the fix! ❤️

[JorTurFer]

/run-e2e pipeline*
Update: You can check the progress here

[JorTurFer]

/run-e2e pipeline
Update: You can check the progress here

[JorTurFer]

The e2e tests are failing due to expired PAT, I'll fix it asap

[JorTurFer]

/run-e2e pipeline
Update: You can check the progress here