Azure DevOps Pipelines Scaler does not respect the required demands if Agent.Version demand does not included

[EugeneLugovtsov]

Report

we have two agent types in one agent pool and if there is no Agent.Version demand keda will scale the wrong agent type.

For example:

First Agent has these demands: Env -equals dev, Type -equals demo1, and second agent Env -equals dev, Type -equals demo2 if there is Agent.Version everything works as expected, however, when Azure DevOps does not provide Agent.Version demand Keda can scale the wrong agent type.

Why?

We are absolutely sure that Agent.Verion will be presented in the required demands and we skip this demand in the final check: len(demandsReq)-1. this -1 causes this issue.

Expected Behavior

Keda respects all required demands even if Agent.Version is not specified.

Actual Behavior

Keda misses one required demand due to a lack of the Agent.Version demand. This issue causes scaling the wrong agent/pod if we have several agent types in one agent pool or it cannot scale agent if there is only one agent type in pool.

Steps to Reproduce the Problem

1. Create an Azure DevOps agent pool with several agents that have these demands Env -equals dev, Type -equals demo1, and Env -equals dev, Type -equals demo2
2. Create Azure DevOps yaml pipeline
3. Trigger yaml pipeline

Logs from KEDA operator

example

KEDA Version

2.10.0

Kubernetes Version

1.25

Platform

Microsoft Azure

Scaler Details

Azure DevOps Pipelines

Anything else?

No response