Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: set VersionTLS12 as min default TLS version #4192

Merged
merged 9 commits into from
Feb 9, 2023
Merged

chore: set VersionTLS12 as min default TLS version #4192

merged 9 commits into from
Feb 9, 2023

Conversation

JorTurFer
Copy link
Member

@JorTurFer JorTurFer commented Feb 2, 2023 •
edited
Loading

Checklist

Relates to ##3961

Fixes #4193

@JorTurFer JorTurFer requested a review from a team as a code owner February 2, 2023 00:13
@JorTurFer JorTurFer changed the title chore: add VersionTLS12 as min default TLS version chore: set VersionTLS12 as min default TLS version Feb 2, 2023
@JorTurFer
update changelog
6966887 
Signed-off-by: Jorge Turrado <[email protected]>
@JorTurFer
fix style
d4453c3 
Signed-off-by: Jorge Turrado <[email protected]>
@JorTurFer
Copy link
Member Author

JorTurFer commented Feb 2, 2023 •
edited by github-actions bot
Loading

/run-e2e
Update: You can check the progress here

@JorTurFer JorTurFer mentioned this pull request Feb 2, 2023
Merged
5 tasks
zroubalik
zroubalik reviewed Feb 2, 2023
View reviewed changes
pkg/util/http.go Outdated Show resolved Hide resolved
@JorTurFer
update the version switch
d26aee5 
Signed-off-by: Jorge Turrado <[email protected]>
@JorTurFer
Copy link
Member Author

JorTurFer commented Feb 2, 2023 •
edited by github-actions bot
Loading

/run-e2e
Update: You can check the progress here

@JorTurFer JorTurFer mentioned this pull request Feb 3, 2023
Closed
zroubalik
zroubalik reviewed Feb 8, 2023
View reviewed changes
Copy link
Member

@zroubalik zroubalik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good, would be nice to add some unit tests, at least for util/http.go 🙏

@JorTurFer
Copy link
Member Author

Looking good, would be nice to add some unit tests, at least for util/http.go 🙏

Sure, I'll refactor the code to extract the function and test it :)

JorTurFer and others added 2 commits February 8, 2023 12:49
@JorTurFer
add a unit test for the parsing
367102d 
Signed-off-by: Jorge Turrado <[email protected]>
@JorTurFer
Merge branch 'main' into set-min-tls
20766c6 
Signed-off-by: Jorge Turrado Ferrero <[email protected]>
@JorTurFer
Copy link
Member Author

JorTurFer commented Feb 8, 2023 •
edited by github-actions bot
Loading

/run-e2e
Update: You can check the progress here

@JorTurFer
Copy link
Member Author

PTAL @zroubalik

zroubalik
zroubalik requested changes Feb 8, 2023
View reviewed changes
pkg/util/http_test.go Show resolved Hide resolved
@JorTurFer @zroubalik
Update pkg/util/http_test.go
6c01ed1 
Co-authored-by: Zbynek Roubalik <[email protected]>
Signed-off-by: Jorge Turrado Ferrero <[email protected]>
zroubalik
zroubalik approved these changes Feb 8, 2023
View reviewed changes
Copy link
Member

@zroubalik zroubalik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, great job!

zroubalik
zroubalik reviewed Feb 8, 2023
View reviewed changes
pkg/util/http_test.go Outdated Show resolved Hide resolved
@zroubalik
Update pkg/util/http_test.go
68ef56b 
Signed-off-by: Zbynek Roubalik <[email protected]>
@JorTurFer
Copy link
Member Author

JorTurFer commented Feb 8, 2023 •
edited by github-actions bot
Loading

/run-e2e
Update: You can check the progress here

@JorTurFer
fix style
7b36edb 
Signed-off-by: Jorge Turrado <[email protected]>
@JorTurFer
Copy link
Member Author

f**k gh editor...
I have fixed format issues locally xD

@JorTurFer JorTurFer merged commit 51807b9 into kedacore:main Feb 9, 2023
@JorTurFer JorTurFer deleted the set-min-tls branch February 9, 2023 10:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zroubalik zroubalik zroubalik approved these changes

Assignees
No one assigned
Labels
skip-e2e
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

KEDA should use TLS12 or above as minimum TLS version
2 participants
@JorTurFer @zroubalik