Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add support to provide custom CAs in KEDA Operator #4191

Merged
merged 8 commits into from
Feb 16, 2023
Merged

feat: Add support to provide custom CAs in KEDA Operator #4191

merged 8 commits into from
Feb 16, 2023

Conversation

JorTurFer
Copy link
Member

@JorTurFer JorTurFer commented Feb 1, 2023 •
edited
Loading

Checklist

Fixes #4168
Fixes #4046

@JorTurFer JorTurFer requested a review from a team as a code owner February 1, 2023 23:09
@JorTurFer
Copy link
Member Author

JorTurFer commented Feb 1, 2023 •
edited by github-actions bot
Loading

/run-e2e custom_ca*
Update: You can check the progress here

semgrep-app[bot]
semgrep-app bot reviewed Feb 1, 2023
View reviewed changes
pkg/util/http.go Outdated Show resolved Hide resolved
@JorTurFer
Copy link
Member Author

JorTurFer commented Feb 1, 2023 •
edited by github-actions bot
Loading

/run-e2e
Update: You can check the progress here

@JorTurFer JorTurFer mentioned this pull request Feb 6, 2023
Closed
7 tasks
semgrep-app[bot]
semgrep-app bot reviewed Feb 7, 2023
View reviewed changes
pkg/util/tls_config.go Outdated Show resolved Hide resolved
@JorTurFer
Copy link
Member Author

JorTurFer commented Feb 7, 2023 •
edited by github-actions bot
Loading

/run-e2e
Update: You can check the progress here

zroubalik
zroubalik reviewed Feb 8, 2023
View reviewed changes
pkg/util/certificates.go Outdated Show resolved Hide resolved
pkg/util/certificates.go Show resolved Hide resolved
tests/internals/global_custom_ca/global_custom_ca_test.go Show resolved Hide resolved
@JorTurFer JorTurFer mentioned this pull request Feb 8, 2023
Closed
semgrep-app[bot]
semgrep-app bot reviewed Feb 9, 2023
View reviewed changes
pkg/util/certificates.go Outdated Show resolved Hide resolved
semgrep-app[bot]
semgrep-app bot reviewed Feb 9, 2023
View reviewed changes
pkg/util/certificates.go Outdated Show resolved Hide resolved
@JorTurFer
Copy link
Member Author

JorTurFer commented Feb 9, 2023 •
edited by github-actions bot
Loading

/run-e2e
Update: You can check the progress here

@JorTurFer
Copy link
Member Author

JorTurFer commented Feb 9, 2023 •
edited
Loading

I haven't updated the docs yet, once the PR is ready (or at least we agree with the CAs path) I'll update docs PR

Updated docs

JorTurFer and others added 8 commits February 12, 2023 14:11
@JorTurFer
update changelog
dbac6c5 
Signed-off-by: Jorge Turrado <[email protected]>
@JorTurFer
update TLS configurations to propagate the HTTP client transport valu…
45d4662 
…es and TLS config CAs

Signed-off-by: Jorge Turrado <[email protected]>
@JorTurFer
returns a copy of rootCAs to keep global CAs unmodifed
2fc583e 
Signed-off-by: Jorge Turrado <[email protected]>
@JorTurFer
integrate changes
4727f8e 
Signed-off-by: Jorge Turrado <[email protected]>
@JorTurFer
fix styles
ff7a623 
Signed-off-by: Jorge Turrado <[email protected]>
@JorTurFer
use proper error checking
19fe05e 
Signed-off-by: Jorge Turrado <[email protected]>
@JorTurFer
add unit tests
a47f71f 
Signed-off-by: Jorge Turrado <[email protected]>
@JorTurFer
fix tests
93429e8 
Signed-off-by: Jorge Turrado <[email protected]>
@JorTurFer
Copy link
Member Author

JorTurFer commented Feb 12, 2023 •
edited by github-actions bot
Loading

/run-e2e
Update: You can check the progress here

zroubalik
zroubalik approved these changes Feb 16, 2023
View reviewed changes
Copy link
Member

@zroubalik zroubalik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job!

@zroubalik zroubalik merged commit cddfca3 into kedacore:main Feb 16, 2023
@JorTurFer JorTurFer deleted the add-custom-cas-support branch February 16, 2023 10:59
@JorTurFer JorTurFer mentioned this pull request Mar 7, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@semgrep-app semgrep-app[bot] semgrep-app[bot] left review comments

@zroubalik zroubalik zroubalik approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add support to add user given CAs to trusted store Keda doesn't work with TLS inspection
2 participants
@JorTurFer @zroubalik