Add 'platformName' to selenium-grid scaler #4105
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Documentation updated: kedacore/keda-docs#1039 |
Signed-off-by: gifflet <[email protected]>
gifflet
force-pushed
the
add-platform-name-to-selenium-grid-scaler
branch
from
39d7525
to
85a58a5
Compare
…data Signed-off-by: gifflet <[email protected]>
zroubalik
reviewed
Jan 16, 2023
Signed-off-by: gifflet <[email protected]>
|
/run-e2e selenium* |
zroubalik
approved these changes
Jan 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
platformName included in the selenium grid scaler metadata so that it is possible to specify the desired platform to run the automated test considering that there are multiplatform nodes such as linux, Windows 10 available in the hub.
Checklist
- [ ] When introducing a new scaler, I agree with the scaling governance policy- [ ] A PR is opened to update our Helm chart (repo) (if applicable, ie. when deployment manifests are modified)Relates to #4038