Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Include platformName to selenium-grid scaler documentation #1039

Merged
merged 1 commit into from
Jan 16, 2023
Merged

Include platformName to selenium-grid scaler documentation #1039

merged 1 commit into from
Jan 16, 2023

Conversation

gifflet
Copy link
Contributor

@gifflet gifflet commented Jan 13, 2023

Included the description of the newly added selenium grid scaler metadata property: platformName.

Checklist

  • Commits are signed with Developer Certificate of Origin (DCO)

Relates to kedacore/keda#4038

@gifflet gifflet requested a review from a team as a code owner January 13, 2023 18:20
@netlify
Copy link

netlify bot commented Jan 13, 2023 •
edited
Loading

✅ Deploy Preview for keda ready!

Name Link
🔨 Latest commit 8ad7e4d
🔍 Latest deploy log https://app.netlify.com/sites/keda/deploys/63c1af7e274ea40008518bb4
😎 Deploy Preview https://deploy-preview-1039--keda.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@gifflet gifflet mentioned this pull request Jan 13, 2023
Merged
5 tasks
tomkerkhove
tomkerkhove suggested changes Jan 13, 2023
View reviewed changes
Copy link
Member

@tomkerkhove tomkerkhove left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Docs look good to me, but can you move them to 2.10 please?

@gifflet gifflet mentioned this pull request Jan 13, 2023
Closed
@gifflet
Copy link
Contributor Author

gifflet commented Jan 13, 2023

Thanks! Docs look good to me, but can you move them to 2.10 please?

OK. I will adjust it.

@gifflet gifflet force-pushed the add-platform-name-to-metadata branch from 2aa6cba to 1718578 Compare January 13, 2023 19:18
@gifflet
Copy link
Contributor Author

gifflet commented Jan 13, 2023

@tomkerkhove, requested changes applied

@gifflet gifflet force-pushed the add-platform-name-to-metadata branch from 1718578 to 09d0b77 Compare January 13, 2023 19:21
@gifflet gifflet force-pushed the add-platform-name-to-metadata branch from 09d0b77 to 8ad7e4d Compare January 13, 2023 19:22
@gifflet
Copy link
Contributor Author

gifflet commented Jan 13, 2023

I noticed that I had made a commit associated with a wrong email so I redid the changes in a new commit. 😅

tomkerkhove
tomkerkhove approved these changes Jan 16, 2023
View reviewed changes
Copy link
Member

@tomkerkhove tomkerkhove left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@tomkerkhove
Copy link
Member

Waiting for feature to be merged

@JorTurFer JorTurFer merged commit c535340 into kedacore:main Jan 16, 2023
@gifflet gifflet deleted the add-platform-name-to-metadata branch January 16, 2023 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomkerkhove tomkerkhove tomkerkhove approved these changes

@zroubalik zroubalik zroubalik approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@gifflet @tomkerkhove @zroubalik @JorTurFer