-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: improve aad-pod-identity errors #3640
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JorTurFer
changed the title
chore: add logs to aad-pod-identity
chore: improve aad-pod-identity errors
Sep 1, 2022
JorTurFer
force-pushed
the
add-info-aad-wi
branch
2 times, most recently
from
September 2, 2022 08:14
05f29da
to
574cf11
Compare
tomkerkhove
approved these changes
Sep 2, 2022
tomkerkhove
reviewed
Sep 2, 2022
tomkerkhove
approved these changes
Sep 2, 2022
@JorTurFer FYI auto-merge won't work |
Nice... when I applied your suggestion, GH decided to not sign my commit 🤦 |
Signed-off-by: Jorge Turrado <[email protected]>
Co-authored-by: Tom Kerkhove <[email protected]> Signed-off-by: Jorge Turrado <[email protected]>
JorTurFer
force-pushed
the
add-info-aad-wi
branch
from
September 2, 2022 12:14
d166d52
to
08abe25
Compare
Known (annoying) bug that I have reported... |
Signed-off-by: Jorge Turrado <[email protected]>
Solved! Thanks for notifying! 🙇 |
andyatwork
pushed a commit
to andyatwork/keda
that referenced
this pull request
Oct 31, 2022
Co-authored-by: Tom Kerkhove <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Jorge Turrado [email protected]
Checklist
Fixes #3610