chore: improve aad-pod-identity errors (#3640)

Co-authored-by: Tom Kerkhove <[email protected]>

CHANGELOG.md

@@ -45,6 +45,7 @@ To learn more about active deprecations, we recommend checking [GitHub Discussio
 ### Improvements
 
 - **General:** Add explicit seccompProfile type to securityContext config ([#3561](https://github.com/kedacore/keda/issues/3561))
+- **Azure AD Pod Identity Authentication:** Improve error messages to emphasize problems around the integration with aad-pod-identity itself ([#3610](https://github.com/kedacore/keda/issues/3610))
 - **Prometheus Scaler:** Introduce skipping of certificate check for unsigned certs ([#2310](https://github.com/kedacore/keda/issues/2310))
 
 ### Fixes

pkg/scalers/azure/azure_aad_podidentity.go

@@ -30,26 +30,26 @@ func GetAzureADPodIdentityToken(ctx context.Context, httpClient util.HTTPDoer, i
 
 	req, err := http.NewRequestWithContext(ctx, "GET", urlStr, nil)
 	if err != nil {
-		return token, err
+		return token, fmt.Errorf("error getting aad-pod-identity token - %w", err)
 	}
 	req.Header = map[string][]string{
 		"Metadata": {"true"},
 	}
 
 	resp, err := httpClient.Do(req)
 	if err != nil {
-		return token, err
+		return token, fmt.Errorf("error getting aad-pod-identity token - %w", err)
 	}
 	defer resp.Body.Close()
 
 	body, err := io.ReadAll(resp.Body)
 	if err != nil {
-		return token, err
+		return token, fmt.Errorf("error getting aad-pod-identity token - %w", err)
 	}
 
 	err = json.Unmarshal(body, &token)
 	if err != nil {
-		return token, errors.New(string(body))
+		return token, fmt.Errorf("error getting aad-pod-identity token - %w", errors.New(string(body)))
 	}
 
 	return token, nil