Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Use mili scale to support more precision #3125

Merged
merged 17 commits into from
Jun 14, 2022

Conversation

JorTurFer
Copy link
Member

@JorTurFer JorTurFer commented Jun 5, 2022

Signed-off-by: Jorge Turrado [email protected]

Checklist

  • Commits are signed with Developer Certificate of Origin (DCO - learn more)
  • Tests have been added
  • Changelog has been updated and is aligned with our changelog requirements

Fixes #3135

Relates to #

Signed-off-by: Jorge Turrado <[email protected]>
@JorTurFer
Copy link
Member Author

JorTurFer commented Jun 5, 2022

/run-e2e azure*
Update: You can check the progres here

@JorTurFer
Copy link
Member Author

JorTurFer commented Jun 5, 2022

/run-e2e aws*
Update: You can check the progres here

Signed-off-by: Jorge Turrado <[email protected]>
Signed-off-by: Jorge Turrado <[email protected]>
Signed-off-by: Jorge Turrado <[email protected]>
@JorTurFer
Copy link
Member Author

JorTurFer commented Jun 5, 2022

/run-e2e
Update: You can check the progres here

@JorTurFer
Copy link
Member Author

JorTurFer commented Jun 6, 2022

/run-e2e
Update: You can check the progres here

Signed-off-by: Jorge Turrado <[email protected]>
Signed-off-by: Jorge Turrado <[email protected]>
Signed-off-by: Jorge Turrado <[email protected]>
Signed-off-by: Jorge Turrado <[email protected]>
Signed-off-by: Jorge Turrado <[email protected]>
@JorTurFer
Copy link
Member Author

JorTurFer commented Jun 6, 2022

/run-e2e mongo*
Update: You can check the progres here

Signed-off-by: Jorge Turrado <[email protected]>
Signed-off-by: Jorge Turrado <[email protected]>
@JorTurFer
Copy link
Member Author

JorTurFer commented Jun 6, 2022

/run-e2e
Update: You can check the progres here

@tomkerkhove
Copy link
Member

Can you create an issue or provide a description so that it's clear what this is about please?

@tomkerkhove
Copy link
Member

Thank you @JorTurFer!

@JorTurFer
Copy link
Member Author

Thank you @JorTurFer!

yw, I should create it before starting... I'll try to do it better next time

@JorTurFer JorTurFer requested review from a team and removed request for a team June 7, 2022 09:42
@JorTurFer
Copy link
Member Author

JorTurFer commented Jun 7, 2022

/run-e2e
Update: You can check the progres here

Signed-off-by: Jorge Turrado <[email protected]>
Signed-off-by: Jorge Turrado <[email protected]>
@JorTurFer JorTurFer marked this pull request as ready for review June 8, 2022 06:34
@JorTurFer JorTurFer requested a review from a team as a code owner June 8, 2022 06:34
@JorTurFer JorTurFer marked this pull request as draft June 8, 2022 06:34
@JorTurFer JorTurFer removed the request for review from a team June 8, 2022 06:34
Signed-off-by: Jorge Turrado <[email protected]>
@JorTurFer JorTurFer marked this pull request as ready for review June 8, 2022 21:27
@JorTurFer JorTurFer changed the title WIP - feat: Use mili scale to support more precision feat: Use mili scale to support more precision Jun 8, 2022
@JorTurFer JorTurFer requested a review from a team June 8, 2022 21:29
Signed-off-by: Jorge Turrado <[email protected]>
@JorTurFer
Copy link
Member Author

JorTurFer commented Jun 8, 2022

/run-e2e
Update: You can check the progres here

Copy link
Member

@zroubalik zroubalik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :)

@JorTurFer JorTurFer merged commit 2698fe1 into kedacore:main Jun 14, 2022
@JorTurFer JorTurFer deleted the use-mili branch June 14, 2022 18:08
aviadlevy pushed a commit to aviadlevy/keda that referenced this pull request Jun 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use mili scale to support more precision
3 participants