Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use mili scale to support more precision #3135

Closed
JorTurFer opened this issue Jun 7, 2022 · 0 comments · Fixed by #3125
Closed

Use mili scale to support more precision #3135

JorTurFer opened this issue Jun 7, 2022 · 0 comments · Fixed by #3125
Assignees
Labels
feature-request All issues for new features that have not been committed to needs-discussion

Comments

@JorTurFer
Copy link
Member

Proposal

K8s supports using different units to bring more precision to the values but right now, all the scalers return an integer quantity in the default unit. This can produce data lost in some cases.

Use-Case

Imagine that you have one metric which is a rate from 0 to 1, with the current approach you can't use KEDA for scaling it without any other different solution but using mili in the target and the value you could do it.

Anything else?

To unify the scaler I'd just return all the metrics/targets in mili. With several scalers doesn't make sense because they are always integers (message count in a queue is an integer), but it will work well even that and unifies the approach across all the scalers

@JorTurFer JorTurFer added needs-discussion feature-request All issues for new features that have not been committed to labels Jun 7, 2022
@JorTurFer JorTurFer changed the title Use mili scale to support more precision Usemili scale to support more precision Jun 7, 2022
@tomkerkhove tomkerkhove moved this to Proposed in Roadmap - KEDA Core Jun 7, 2022
@JorTurFer JorTurFer changed the title Usemili scale to support more precision Use mili scale to support more precision Jun 7, 2022
@JorTurFer JorTurFer self-assigned this Jun 7, 2022
@JorTurFer JorTurFer moved this from Proposed to In Progress in Roadmap - KEDA Core Jun 7, 2022
Repository owner moved this from In Progress to Ready To Ship in Roadmap - KEDA Core Jun 14, 2022
@tomkerkhove tomkerkhove moved this from Ready To Ship to Done in Roadmap - KEDA Core Aug 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-request All issues for new features that have not been committed to needs-discussion
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

1 participant