Add GCP stackdriver aggregation parameters

[RamCohen]

Fixes #3008

Docs: kedacore/keda-docs#776

Signed-off-by: Ram Cohen [email protected]

[RamCohen]

Will open a documentation PR if this is tentatively approved

[zroubalik]

Looking good in general, nice impovement, thanks!

[RamCohen]

Not sure what to do with the annoying unrelated static check failure:
pkg/scalers/azure_blob_scaler.go:131:102: string true has 3 occurrences, make it a constant (goconst)

[JorTurFer]

Not sure what to do with the annoying unrelated static check failure:
pkg/scalers/azure_blob_scaler.go:131:102: string true has 3 occurrences, make it a constant (goconst)

IDK why this happens only in your PR and not in others... You could just refactor it a bit, something like this:

	if val, ok := config.TriggerMetadata["useAAdPodIdentity"]; ok {
		value, err := strconv.ParseBool(val)
		if err != nil {
			return nil, "", err
		}
		if config.PodIdentity == "" && value {
			config.PodIdentity = kedav1alpha1.PodIdentityProviderAzure
		}
	}

[zroubalik]

Not sure what to do with the annoying unrelated static check failure:
pkg/scalers/azure_blob_scaler.go:131:102: string true has 3 occurrences, make it a constant (goconst)

IDK why this happens only in your PR and not in others... You could just refactor it a bit, something like this:

	if val, ok := config.TriggerMetadata["useAAdPodIdentity"]; ok {
		value, err := strconv.ParseBool(val)
		if err != nil {
			return nil, "", err
		}
		if config.PodIdentity == "" && value {
			config.PodIdentity = kedav1alpha1.PodIdentityProviderAzure
		}
	}

It is happening because another "true" has been added in this PR in pkg/scalers/stackdriver_client.go.

[JorTurFer]

It is happening because another "true" has been added in this PR in pkg/scalers/stackdriver_client.go.

lol, good catch, I didn't see it 👁️

[RamCohen]

changed the switch statement to use "count_true" and "count_false" so that should solve it

[zroubalik]

/run-e2e
Update: You can check the progress here

[zroubalik]

LGTM

[zroubalik]

/run-e2e gcp*
Update: You can check the progress here

// Zbynek update: transient env failure.

[zroubalik]

/run-e2e gcp*
Update: You can check the progress here

[zroubalik]

@RamCohen e2e tests failed on this one. Btw we also have started a migration of e2e tests from TS to Go, do you think you can try to tackle this? Thanks!

[RamCohen]

I saw that but I can't see how to get to the logs to see what happens As for TS to Go: Will be happy to once I see some examples of other tests

…

On Fri, Jun 17, 2022, 10:20 Zbynek Roubalik ***@***.***> wrote: @RamCohen <https://github.com/RamCohen> e2e tests failed on this one. Btw we also have started a migration of e2e tests from TS to Go, do you think you can try to tackle this? Thanks! — Reply to this email directly, view it on GitHub <#3070 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AATJ7GTCTN4KWKOR4QXX2W3VPQRNNANCNFSM5W5N6NYA> . You are receiving this because you were mentioned.Message ID: ***@***.***>

[JorTurFer]

I saw that but I can't see how to get to the logs to see what happens

Hey,
You can click in the link that the GH action has updated and scroll inside the step "Run end to end tests". This is the link to one of the logs

[zroubalik]

/run-e2e gcp*
Update: You can check the progress here

[zroubalik]

@RamCohen #2737

Here you can see initial migration to Golang based tests. Also the readme has been updated: https://github.com/kedacore/keda/blob/main/tests/README.md

[tomkerkhove]

/run-e2e gcp*

Update: You can check the progress here

[RamCohen]

looks like no tests were actually run

[zroubalik]

@JorTurFer mind looking at this^

[zroubalik]

/run-e2e gcp*
Update: You can check the progress here

[zroubalik]

/run-e2e gcp*
Update: You can check the progress here

[zroubalik]

/run-e2e gcp*
Update: You can check the progress here

[zroubalik]

/run-e2e gcp*
Update: You can check the progress here

[zroubalik]

@RamCohen could you please update Changelog?

[zroubalik]

/run-e2e gcp*
Update: You can check the progress here

[ritmas]

When could this be released @zroubalik @RamCohen ?