Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Argo Rollouts e2e test #1261

Merged
merged 4 commits into from
Oct 15, 2020
Merged

Add Argo Rollouts e2e test #1261

merged 4 commits into from
Oct 15, 2020

Conversation

anggao
Copy link
Contributor

@anggao anggao commented Oct 15, 2020

Signed-off-by: Ang Gao [email protected]

Add Argo Rollouts e2e test, followed prometheus.test.ts as an example

Checklist

Fixes #1234

@anggao
Fix typo
732d169 
Signed-off-by: Ang Gao <[email protected]>
zroubalik
zroubalik approved these changes Oct 15, 2020
View reviewed changes
Copy link
Member

@zroubalik zroubalik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just minor correction in Changelog

Thanks for the contribution, this is really great!

CHANGELOG.md Outdated Show resolved Hide resolved
@zroubalik zroubalik merged commit bc61b4f into kedacore:v2 Oct 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zroubalik zroubalik zroubalik approved these changes

@ahmelsayed ahmelsayed Awaiting requested review from ahmelsayed

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add Argo Rollouts e2e test
2 participants
@anggao @zroubalik