Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Argo Rollouts e2e test #1234

Closed
zroubalik opened this issue Oct 9, 2020 · 2 comments · Fixed by #1261
Closed

Add Argo Rollouts e2e test #1234

zroubalik opened this issue Oct 9, 2020 · 2 comments · Fixed by #1261
Labels
good first issue Good for newcomers Hacktoberfest testing

Comments

@zroubalik
Copy link
Member

KEDA v2 can scale CustomResource, we should add scenario to cover Argo Rollouts.

We can reuse existing Scalers e2e tests, just add the target deployment as a Argo Rollout

E2E test: https://github.com/kedacore/keda/tree/v2/tests
@anggao
Copy link
Contributor

anggao commented Oct 13, 2020

@zroubalik I can do this, if no one take it :)

@zroubalik
Copy link
Member Author

@anggao great, go ahead!

@anggao anggao mentioned this issue Oct 15, 2020
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers Hacktoberfest testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add Argo Rollouts e2e test anggao/keda
2 participants
@anggao @zroubalik