Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[v2] add support for multiple redis list types in redis list scaler #1013

Merged
merged 2 commits into from
Aug 20, 2020
Merged

[v2] add support for multiple redis list types in redis list scaler #1013

merged 2 commits into from
Aug 20, 2020

Conversation

ilyamor
Copy link
Contributor

@ilyamor ilyamor commented Aug 19, 2020 •
edited
Loading

added support for multiple redis "list" types scaling, including : zset,hash,set and list

Checklist

Fixes #

@ilyamor ilyamor changed the title V2 add support for multiple redis list types in redis list scaler #1006 Aug 19, 2020
@ilyamor ilyamor changed the title add support for multiple redis list types in redis list scaler #1006 add support for multiple redis list types in redis list scaler Aug 19, 2020
@ilyamor ilyamor mentioned this pull request Aug 19, 2020
Closed
4 tasks
@ilyamor
Copy link
Contributor Author

ilyamor commented Aug 19, 2020 •
edited
Loading

original discussion
#1006

@zroubalik zroubalik changed the title add support for multiple redis list types in redis list scaler [v2 ]add support for multiple redis list types in redis list scaler Aug 19, 2020
@zroubalik zroubalik changed the title [v2 ]add support for multiple redis list types in redis list scaler [v2] add support for multiple redis list types in redis list scaler Aug 19, 2020
zroubalik
zroubalik approved these changes Aug 19, 2020
View reviewed changes
Copy link
Member

@zroubalik zroubalik left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not redis-list expert, but LGTM

@ilyamor
Copy link
Contributor Author

ilyamor commented Aug 20, 2020

how is the merge process works?when is v2 suppose to be out?

@zroubalik
Copy link
Member

zroubalik commented Aug 20, 2020 •
edited
Loading

@ilyamor could you plese fix hour PR on the docs? I think that we can merge this one then.

v2 should be out in the next couple of weeks. Feel free to join community meetup later today, to get more details.

@ahmelsayed ahmelsayed merged commit b286338 into kedacore:v2 Aug 20, 2020
This was referenced Sep 1, 2020
Closed
Merged
SpiritZhou pushed a commit to SpiritZhou/keda that referenced this pull request Jul 18, 2023
@JorTurFer @tomkerkhove
docs: add new parameter unsafeSsl (kedacore#1013)
ad373e4 
Co-authored-by: Tom Kerkhove <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zroubalik zroubalik zroubalik approved these changes

@ahmelsayed ahmelsayed Awaiting requested review from ahmelsayed

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ilyamor @zroubalik @ahmelsayed