add support for multiple redis list types in redis list scaler #1006
Conversation
Signed-off-by: ilyamor <[email protected]>
This can be found on https://github.com/kedacore/keda/blob/master/CHANGELOG.md Thanks for updating! |
| } | ||
|
|
||
| var cmd *redis.IntCmd | ||
| switch listType.Val() { |
There was a problem hiding this comment.
Do we just pull from the correct type or does the type have to be configured?
There was a problem hiding this comment.
The way I'm reading the change, and I'm no redis expert btw, is that the particular list we're trying to scale on could have different types that require a different call on the client. I think the approach looks fine to me.
There was a problem hiding this comment.
Do we just pull from the correct type or does the type have to be configured?
it may be configured by the user but we sill will have to do switch casing on it for different api call to redis, so this approach is more flexible to the user
There was a problem hiding this comment.
If it's a type of list, then it's ok for me but if it's a different type of entity I would make it configurable on what people want to get
There was a problem hiding this comment.
lets call it collection instead of a list, and you have different type of collections(list, set, map, etc ..) that all have "name" and "length" and those are the only parameters i would want the user to configure
|
|
||
| cmd := client.LLen(listName) | ||
| listType = client.Type(listName) |
There was a problem hiding this comment.
Not sure if list name is appropriate here
There was a problem hiding this comment.
any other suggestions ?
|
Docs are up on kedacore/keda-docs#231. Just out of curiosity - Why can't we add a test for this? |
|
Could you please open this PR against v2 branch? We don't expect to bring any big features to v1. |
Signed-off-by: ilyamor <[email protected]>
|
open new pr to v2 |
the test will not cover any business logic only "testing the database" |
added support for multiple redis "list" types scaling, including : zset,hash,set and list
Checklist
Fixes #