Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Supporting Kubernetes recommended labels #536

Closed
Cottonglow opened this issue Jan 8, 2020 · 2 comments · Fixed by #596 or kedacore/charts#21
Closed

Supporting Kubernetes recommended labels #536

Cottonglow opened this issue Jan 8, 2020 · 2 comments · Fixed by #596 or kedacore/charts#21
Labels
feature-request All issues for new features that have not been committed to good first issue Good for newcomers help wanted Looking for support from community needs-discussion

Comments

@Cottonglow
Copy link
Contributor

Kubernetes recommends some shared labels to apply to resources to help manage the cluster. Some of the KEDA resources either don't have any labels at all or are a bit lacking, making them harder to manage.

The HPA that is created by KEDA also doesn't have any labels and these labels could help differentiate it from self-managed HPAs.

Use-Case

These are the labels that Kubernetes recommends to add to the resources:

app.kubernetes.io/name
app.kubernetes.io/instance
app.kubernetes.io/version
app.kubernetes.io/component
app.kubernetes.io/part-of
app.kubernetes.io/managed-by

What are the thoughts on this and/or is this planned for KEDA in the future?

@Cottonglow Cottonglow added feature-request All issues for new features that have not been committed to needs-discussion labels Jan 8, 2020
@tomkerkhove
Copy link
Member

I like the idea! Most of it should be done via our chart/operator but our HPAs should have them as well.

@jeffhollan jeffhollan added help wanted Looking for support from community good first issue Good for newcomers labels Jan 9, 2020
@Cottonglow
Copy link
Contributor Author

I can have a look at adding them, and then we can discuss in the PR what labels/values we want to keep or use.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-request All issues for new features that have not been committed to good first issue Good for newcomers help wanted Looking for support from community needs-discussion
Projects
None yet
3 participants