Add recommended kubernetes labels to helm chart #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cottonglow
requested review from
ahmelsayed,
jeffhollan and
tomkerkhove
as code owners
4 tasks
|
Thanks @Cottonglow - LGTM. @ahmelsayed let me know if you have any concerns |
jeffhollan
approved these changes
Feb 4, 2020
|
@Cottonglow can you rebase or merge @robece changes in #17 |
|
@ahmelsayed Done :) |
ahmelsayed
approved these changes
Feb 6, 2020
|
Thank you @Cottonglow :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The intent behind this PR is to open a discussion and decide on what labels we want to add, the values we want and which resources they should be on (It is recommended to apply the labels on every resource object - https://kubernetes.io/docs/concepts/overview/working-with-objects/common-labels/).
I picked the labels that seemed reasonable to me and the values that made sense.
Checklist
Fixes kedacore/keda#536