Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ctrl keys in terminal should pass to shell #250

Closed
jkottler opened this issue Jan 10, 2022 · 2 comments
Closed

Ctrl keys in terminal should pass to shell #250

jkottler opened this issue Jan 10, 2022 · 2 comments
Assignees
@kasecato
Labels
bug
Milestone
v1.5.3

Comments

@jkottler
Copy link

jkottler commented Jan 10, 2022 •
edited
Loading

OS: MacOS

When the terminal window has focus, keys should be sent to the terminal / shell instead of being captured by the keymaps.

For example: pressing ctrl+r in the terminal should activate my command line history search, not begin the run action.

This defect has caused me to disable the extension, which I was very pleased to find until I discovered this.
@hunterli
Copy link

{
"key": "ctrl+r",
"command": "workbench.action.terminal.sendSequence",
"args": { "text": "\u0012" },
"when": "terminalFocus"
},

@kasecato kasecato self-assigned this Jul 27, 2022
@kasecato
Copy link
Owner

kasecato commented Sep 19, 2022 •
edited
Loading

Let me add a ctrl+r trigger when !terminalFocus

@kasecato kasecato added the bug label Sep 19, 2022
@kasecato kasecato added this to the v1.5.3 milestone Sep 19, 2022
kasecato added a commit that referenced this issue Sep 19, 2022
@kasecato
Merge pull request #273 from kasecato/#250/terminalMissFire
3214b01 
Fixed #250 that is Ctrl keys in terminal should pass to shell
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kasecato kasecato

Labels
bug
Projects
None yet
Milestone
v1.5.3
Development

No branches or pull requests
3 participants
@hunterli @jkottler @kasecato