-
Notifications
You must be signed in to change notification settings - Fork 876
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
operator/pkg/controlplane/etcd: remove redundant EtcdPeerServiceName
#5592
base: master
Are you sure you want to change the base?
operator/pkg/controlplane/etcd: remove redundant EtcdPeerServiceName
#5592
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
cc: @zhzhuang-zju |
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #5592 +/- ##
==========================================
+ Coverage 34.14% 34.83% +0.69%
==========================================
Files 643 645 +2
Lines 44524 44832 +308
==========================================
+ Hits 15203 15618 +415
+ Misses 28165 28010 -155
- Partials 1156 1204 +48
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Signed-off-by: Mohamed Awnallah <[email protected]>
004d1a5
to
b04f90a
Compare
Description
In this commit, we remove the redundant field
EtcdPeerServiceName
in the functioninstallKarmadaEtcd
inoperator/pkg/controlplane/etcd
package.What type of PR is this?
/kind cleanup
Which issue(s) this PR fixes:
Fixes #5584
Does this PR introduce a user-facing change?: