Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

operator/pkg/controlplane/etcd: remove redundant EtcdPeerServiceName #5592

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

mohamedawnallah
Copy link
Contributor

Description

In this commit, we remove the redundant field EtcdPeerServiceName in the function installKarmadaEtcd in operator/pkg/controlplane/etcd package.

What type of PR is this?

/kind cleanup

Which issue(s) this PR fixes:
Fixes #5584

Does this PR introduce a user-facing change?:

NONE

@karmada-bot karmada-bot added the kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. label Sep 23, 2024
@karmada-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign lonelycz for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@karmada-bot karmada-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Sep 23, 2024
@mohamedawnallah
Copy link
Contributor Author

cc: @zhzhuang-zju

@codecov-commenter
Copy link

codecov-commenter commented Sep 23, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.

Project coverage is 34.83%. Comparing base (4c8bcd4) to head (b04f90a).
Report is 48 commits behind head on master.

Files with missing lines Patch % Lines
operator/pkg/controlplane/etcd/etcd.go 0.00% 4 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5592      +/-   ##
==========================================
+ Coverage   34.14%   34.83%   +0.69%     
==========================================
  Files         643      645       +2     
  Lines       44524    44832     +308     
==========================================
+ Hits        15203    15618     +415     
+ Misses      28165    28010     -155     
- Partials     1156     1204      +48     
Flag Coverage Δ
unittests 34.83% <0.00%> (+0.69%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Is EtcdPeerServiceName field in installKarmadaEtcd redundant in operator/pkg/controlplane/etcd?
4 participants