Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Is EtcdPeerServiceName field in installKarmadaEtcd redundant in operator/pkg/controlplane/etcd? #5584

Open
mohamedawnallah opened this issue Sep 21, 2024 · 4 comments · May be fixed by #5592
Open

Is EtcdPeerServiceName field in installKarmadaEtcd redundant in operator/pkg/controlplane/etcd? #5584

mohamedawnallah opened this issue Sep 21, 2024 · 4 comments · May be fixed by #5592
Assignees
@zhzhuang-zju
Labels
kind/question Indicates an issue that is a support question.

Comments

@mohamedawnallah
Copy link
Contributor

mohamedawnallah commented Sep 21, 2024 •
edited
Loading

Description

While testing the etcd control plane in the operator package (#5583), I noticed that the EtcdPeerServiceName on installKarmadaEtcd is not embedded or utilized in the etcd manifest. Is it currently redundant and we should remove it?
@mohamedawnallah mohamedawnallah added the kind/question Indicates an issue that is a support question. label Sep 21, 2024
@mohamedawnallah mohamedawnallah changed the title Is EtcdPeerServiceName in installKarmadaEtcd Redundant in operator/pkg/controlplane/etcd? Is EtcdPeerServiceName field in installKarmadaEtcd redundant in operator/pkg/controlplane/etcd? Sep 22, 2024
@zhzhuang-zju
Copy link
Contributor

/assign

@zhzhuang-zju
Copy link
Contributor

Good find! EtcdPeerServiceName was introduced in #3102 as part of command flag initial-cluster. Now the assignment of initial-cluster has been moved into the function installKarmadaEtcd in #3349. I think EtcdPeerServiceName is redundant, and we can remove it.

@zhzhuang-zju
Copy link
Contributor

@mohamedawnallah Would you like to submit a PR to remove the redundant field?

@mohamedawnallah mohamedawnallah linked a pull request Sep 23, 2024 that will close this issue
Open
@mohamedawnallah
Copy link
Contributor Author

Thanks @zhzhuang-zju! I've just submitted a PR for this. Would love to receive any feedback! 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zhzhuang-zju zhzhuang-zju

Labels
kind/question Indicates an issue that is a support question.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

operator/pkg/controlplane/etcd: remove redundant EtcdPeerServiceName mohamedawnallah/karmada
2 participants
@mohamedawnallah @zhzhuang-zju