Removed peer dependencies. #846
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Yep, there's an issue for this #767. We need to update So, can you please:
|
Peer dependencies should not go from the parent to the children. The children should peer depend on the parent project and not the other way around. Closes karma-runner#767 BREAKING CHANGE: People will need to explicitly install the plugins they need. `karma init` should help with this. Removed plugins that need to be installed explicitly are: * karma-jasmine * karma-requirejs * karma-coffee-preprocessor * karma-html2js-preprocessor * karma-chrome-launcher * karma-firefox-launcher * karma-phantomjs-launcher * karma-script-launcher
|
Updated the commit message as @vojtajina suggested. |
|
I updated the msg and merged it as e033d56. Thanks @andersjanmyr |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Peer dependencies should not go from the parent to the children. The children
should peer-depend on the parent project and not the other way around.