Peer Dependencies #767
Comments
|
@eddiemonge yep, you are correct the only reason is so that you can just install karma and it works (it includes karma-jasmine and some other default plugins). Each plugin has a peerDependency on Karma. Maybe we could have |
|
I'd really love to see this go as well because it wastes quite some time downloading dependencies I don't need in my projects. How about having a separate module, something like It's just an incomplete/opinionated set of dependencies anyway, if you use |
|
@c089 I can see doing this in 0.12, also |
andersjanmyr
pushed a commit
to andersjanmyr/karma
that referenced
this issue
Dec 6, 2013
Peer dependencies should not go from the parent to the children. The children should peer depend on the parent project and not the other way around. Closes karma-runner#767 BREAKING CHANGE: People will need to explicitly install the plugins they need. `karma init` should help with this. Removed plugins that need to be installed explicitly are: * karma-jasmine * karma-requirejs * karma-coffee-preprocessor * karma-html2js-preprocessor * karma-chrome-launcher * karma-firefox-launcher * karma-phantomjs-launcher * karma-script-launcher
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Shouldn't the things listed as peerDependencies in the package.json be dependencies? And if Karma doesn't depend on them and they really are optional plugins, shouldn't they have karma listed as a peerDependency and karma not have them listed at all?
Only reason I see to have them listed as PD's in Karma is so they are automatically installed to make it easier for devs to use them. I think this is a bad case and adds a lot of unneeded bloat. I think they better solution would be to document that if you want, say coffeescript support, then youhave to
npm install --save-dev karma-coffee-preprocessorin your project (or add it globally to run karma standalone).The text was updated successfully, but these errors were encountered: