Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: lint and commitlint in its own workflow #313

Merged
merged 4 commits into from
Apr 11, 2022
Merged

ci: lint and commitlint in its own workflow #313

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
394ba52
ci: lint and commitlint in its own workflow
Apr 4, 2022
4ad9e61
ci: refactor: execute each test suite in its own step
Apr 4, 2022
ae80555
build: fix: use an eslint version compatible with Node.js 10
Apr 4, 2022
5fc94e8
ci: run linting only in the oldest Node.js we support
Apr 6, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
33 changes: 33 additions & 0 deletions .github/workflows/lint.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,33 @@
name: Lint

on:
pull_request:
branches:
- master

jobs:
linux:
name: "Node ${{ matrix.node }} on Linux: Lint"
jginsburgn marked this conversation as resolved.
Show resolved Hide resolved
runs-on: ubuntu-latest
strategy:
fail-fast: false
matrix:
jginsburgn marked this conversation as resolved.
Show resolved Hide resolved
node:
- 10
- 12
- 14
- 16
steps:
- uses: actions/checkout@v3
with:
fetch-depth: 0
jginsburgn marked this conversation as resolved.
Show resolved Hide resolved
- uses: actions/setup-node@v3
with:
node-version: ${{ matrix.node }}
cache: npm
- run: npm ci
- run: npm run lint
- run: |
XhmikosR marked this conversation as resolved.
Show resolved Hide resolved
npm run commitlint -- \
--verbose \
--from `git merge-base origin/master $GITHUB_SHA`
4 changes: 3 additions & 1 deletion .github/workflows/release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,5 +28,7 @@ jobs:
--verbose \
--from `git merge-base origin/master $GITHUB_SHA`
- run: npm run build
- run: npm run test
- run: npm run test:unit
- run: npm run test:e2e
- run: npm run test:integration
- run: npm run release
8 changes: 2 additions & 6 deletions .github/workflows/test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ on:

jobs:
linux:
name: "Node ${{ matrix.node }} on Linux: Test and Lint"
name: "Node ${{ matrix.node }} on Linux: Test"
runs-on: ubuntu-latest
strategy:
fail-fast: false
Expand All @@ -27,16 +27,12 @@ jobs:
node-version: ${{ matrix.node }}
cache: npm
- run: npm ci
- run: |
npm run commitlint -- \
--verbose \
--from `git merge-base origin/master $GITHUB_SHA`
- run: npm run build
- run: npm run test:unit
- run: npm run test:e2e
- run: npm run test:integration
windows:
name: "Node ${{ matrix.node }} on Windows: Test and Lint"
name: "Node ${{ matrix.node }} on Windows: Test"
runs-on: windows-latest
defaults:
run:
Expand Down
Loading