Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: lint and commitlint in its own workflow #313

Merged
merged 4 commits into from
Apr 11, 2022
Merged

Conversation

jginsburgn
Copy link
Member

Fixes #311

@jginsburgn jginsburgn requested a review from XhmikosR April 4, 2022 19:38
.github/workflows/lint.yml Outdated Show resolved Hide resolved
.github/workflows/lint.yml Outdated Show resolved Hide resolved
@jginsburgn
Copy link
Member Author

Tell me if I am wrong. @devoto13 wants linting (commit and source) to be done in a job under the test.yml workflow and @XhmikosR prefers it to be done in its own workflow (i.e. lint.yml). I can go with both. Let's just get to an agreement.

@XhmikosR
Copy link
Collaborator

XhmikosR commented Apr 6, 2022

IMHO opinion commitlint shouldn't block the other tests, so the only way to achieve this is to have it in a separate workflow (separate workflow doesn't necessarily mean a separate workflow file BTW, although it wasn't possible to restart individual workflows until recently).

@jginsburgn
Copy link
Member Author

IMHO opinion commitlint shouldn't block the other tests, so the only way to achieve this is to have it in a separate workflow (separate workflow doesn't necessarily mean a separate workflow file BTW, although it wasn't possible to restart individual workflows until recently).

I agree that it should not block other tests.

IIUC there is a one-to-one relation between a workflow and a file (reference).

Also, besides doing linting in its own workflow, we can do it in its own job and use if: ${{ always() }} for the other testing jobs to make sure they run regardless of the success status of the linting one (reference).

@XhmikosR
Copy link
Collaborator

XhmikosR commented Apr 6, 2022

Nowadays, you can restart single workflows, so we can just have one workflow file. I'll let you decide, I don't have strong feelings about it as long as the other tests are not blocked.

@jginsburgn
Copy link
Member Author

Nowadays, you can restart single workflows, so we can just have one workflow file. I'll let you decide, I don't have strong feelings about it as long as the other tests are not blocked.

I prefer its own file. Are you good with that @devoto13 ?

Copy link
Collaborator

@devoto13 devoto13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you good with that @devoto13 ?

Everything LGTM

@jginsburgn jginsburgn merged commit dd50806 into master Apr 11, 2022
@jginsburgn jginsburgn deleted the independent-linting branch April 11, 2022 02:00
@karmarunnerbot
Copy link
Member

🎉 This PR is included in version 5.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

jginsburgn pushed a commit to karma-runner/karma that referenced this pull request Apr 13, 2022
jginsburgn pushed a commit to karma-runner/karma that referenced this pull request Apr 19, 2022
anthony-redFox pushed a commit to anthony-redFox/karma that referenced this pull request May 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Linting Should Run in Its Own Workflow
4 participants