-
Notifications
You must be signed in to change notification settings - Fork 163
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: lint and commitlint in its own workflow #313
Conversation
0f6248b
to
394ba52
Compare
This allows for easier reading of failures.
IMHO opinion commitlint shouldn't block the other tests, so the only way to achieve this is to have it in a separate workflow (separate workflow doesn't necessarily mean a separate workflow file BTW, although it wasn't possible to restart individual workflows until recently). |
I agree that it should not block other tests. IIUC there is a one-to-one relation between a workflow and a file (reference). Also, besides doing linting in its own workflow, we can do it in its own job and use |
Nowadays, you can restart single workflows, so we can just have one workflow file. I'll let you decide, I don't have strong feelings about it as long as the other tests are not blocked. |
I prefer its own file. Are you good with that @devoto13 ? |
c825542
to
5fc94e8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are you good with that @devoto13 ?
Everything LGTM
🎉 This PR is included in version 5.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Source of inspiration: karma-runner/karma-jasmine#313
Source of inspiration: karma-runner/karma-jasmine#313
Source of inspiration: karma-runner/karma-jasmine#313
Fixes #311