Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ruby/Romaji's index should be char index #2009

Closed
3 tasks done
andy840119 opened this issue May 14, 2023 · 1 comment
Closed
3 tasks done

Ruby/Romaji's index should be char index #2009

andy840119 opened this issue May 14, 2023 · 1 comment
Labels
enhancement New feature or request
Milestone
2023.0606

Comments

@andy840119
Copy link
Member

andy840119 commented May 14, 2023 •
edited
Loading

Because it's reasonable for the data layer

Should adjust those package:
@andy840119 andy840119 changed the title Ruby/Romano's index should be chat index Ruby/Romaji's index should be chat index May 14, 2023
@andy840119 andy840119 mentioned this issue May 14, 2023
Closed
@andy840119 andy840119 changed the title Ruby/Romaji's index should be chat index Ruby/Romaji's index should be char index May 14, 2023
This was referenced May 23, 2023
Closed
Merged
andy840119 added a commit to andy840119/karaoke that referenced this issue May 26, 2023
@andy840119
Upgrade some package to the latest to make sure that position text in…
4f5b5d0 
… the package is char index.

see the change in the karaoke-dev#2009
@andy840119 andy840119 added the enhancement New feature or request label May 27, 2023
@andy840119 andy840119 mentioned this issue May 27, 2023
Merged
@andy840119 andy840119 added this to the 2023.0606 milestone May 27, 2023
@andy840119
Copy link
Member Author

Implemented.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
2023.0606
Development

No branches or pull requests
1 participant
@andy840119