New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Breaking change] Ruby's index should be the lyric's char index #44

Merged

andy840119 merged 2 commits into karaoke-dev:main from andy840119:record-char-index-instead

May 24, 2023

Member

andy840119 commented May 24, 2023

Closes issue #43.

andy840119 added 2 commits

May 24, 2023 22:40


          Implement the utils for able to convert the text index into the char …

33f4a68

…index.


          Should store the char index instead of gap index in the ruby tag.

d98274a

andy840119 added the code quality label

pull-request-size bot added the size/L label

andy840119 changed the title ~~Ruby's index should be the lyric's char index~~ [Breaking change] Ruby's index should be the lyric's char index

andy840119 merged commit 314a7f4 into karaoke-dev:main

andy840119 deleted the record-char-index-instead branch

May 24, 2023 14:43

andy840119 mentioned this pull request

Ruby/Romaji's index should be char index karaoke-dev/karaoke#2009

Closed

3 tasks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

code quality size/L