-
Notifications
You must be signed in to change notification settings - Fork 15
Producing and consuming messages tw review #197
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+250
−167
Merged
Changes from 9 commits
Commits
Show all changes
20 commits
Select commit
Hold shift + click to select a range
1b3306c
title change
sabinaptas 696c701
Merge branch 'master' into home_changes
sabinaptas e5f5470
First edits in Concuming and TW topics
sabinaptas 9650fe4
Linter fixes
sabinaptas 9df5d82
Test step added
sabinaptas 4cfb611
Merge branch 'master' of github.com:karafka/wiki into Producing-and-C…
sabinaptas a60db6e
wip
sabinaptas 71096ea
Changes up to Detecting section
sabinaptas f7e9c0a
Changes up to Shutdown
sabinaptas d6421eb
Review completed
sabinaptas fab3b9d
Merge branch 'master' into Producing-and-Consuming-Messages-TW-Review
mensfeld d27cb5d
Complete review of the Producing chapter
sabinaptas e8a013c
Merge branch 'Producing-and-Consuming-Messages-TW-Review' of github.c…
sabinaptas 7720640
Merge remote-tracking branch 'origin' into Producing-and-Consuming-Me…
sabinaptas 9a709c4
2nd round of review (incl. author's fixes)
sabinaptas 3310a23
Merge branch 'master' of github.com:karafka/wiki into Producing-and-C…
sabinaptas 8a6e6f8
Linters for 4 files
sabinaptas c6f562f
Linter - Round 2
sabinaptas df0602e
Linter - Round 3
sabinaptas b57043d
Merge branch 'master' into Producing-and-Consuming-Messages-TW-Review
mensfeld File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,6 @@ | ||
| # Best Practices | ||
|
|
||
| ## Documents structure and sources | ||
|
|
||
| 1. H1 and H2 headers in th TOC (Wiki) are rendered from the home.md file. Edit them directly in the home.md file. Renaming the titles in the navigation pane in the VS Code editor does nothing. | ||
sabinaptas marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
| 2. Test step | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.