-
Notifications
You must be signed in to change notification settings - Fork 15
Producing and consuming messages tw review #197
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Consuming-Messages.md
Outdated
| Karafka framework has a long-running server process responsible for fetching and consuming messages. Consumers should inherit from the **ApplicationConsumer**. You need to define a ```#consume``` method that will execute your business logic code against a batch of messages. Karafka fetches and consumes messages in batches by default. | ||
|
|
||
| Karafka fetches and consumes messages in batches by default. | ||
| ### Consuming Messages in Batches |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
my mistake here, it will be changed to H2
Consuming-Messages.md
Outdated
| ``` | ||
| **Result:** The `#consume_one` method will be called for each message in the batch, allowing you to process messages individually while maintaining the benefits of Karafka's batch fetching. | ||
|
|
||
| ### Accessing Topic Details |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Currently, in Wiki it is H3 displayed under the Consuming Messages Topic. Is it a subsection? Or can I move it/treat it as H2 in TOC? I understood, it is a separate procedure from Consuming Messages (in batches or individually) per se.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have finished the first round of the whole "Consuming Messages" chapter. Please, go through the changes and reply to my comments :-).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I submit review again.
…om:karafka/wiki into Producing-and-Consuming-Messages-TW-Review
…onsuming-Messages-TW-Review
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mensfeld all checks are correct. Please merge these files, deploy them and let me know when to close the PR.
No description provided.