Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Session 3: Error #3

Merged
merged 15 commits into from
Feb 22, 2024
Merged

Session 3: Error #3

merged 15 commits into from
Feb 22, 2024

Conversation

kantacky
Copy link
Owner

Session 3: Error

Updates

  • APIのメソッドを呼び出した時のエラーハンドリングを追加
  • エラーの種類ごとにエラーメッセージを追加
  • ForecastViewでエラーメッセージを表示するalertモディファイアを追加

@macneko-ayu
Copy link

5d01d7d の修正により、ビルドが通らない状態になっています。
ベースブランチがマージされるまで、Draft or WIP にしていただけますか。
おそらく Session 4 以降のPRも同様の問題が発生していると思います

@kantacky
Copy link
Owner Author

5d01d7d の修正により、ビルドが通らない状態になっています。 ベースブランチがマージされるまで、Draft or WIP にしていただけますか。 おそらく Session 4 以降のPRも同様の問題が発生していると思います

ありがとうございます!
修正したので、おそらくビルドが通るかと思います。

@kantacky
Copy link
Owner Author

#7 でLocalizedErrorを使って実装しています。

YumemiTraining/ForecastViewModel.swift Outdated Show resolved Hide resolved
YumemiTraining/ForecastViewModel.swift Outdated Show resolved Hide resolved
YumemiTraining/ForecastViewModel.swift Outdated Show resolved Hide resolved
YumemiTraining/ForecastView.swift Outdated Show resolved Hide resolved
YumemiTraining/ForecastView.swift Outdated Show resolved Hide resolved
@kantacky kantacky requested a review from ykws February 21, 2024 07:39
YumemiTraining/ForecastViewModel.swift Outdated Show resolved Hide resolved
YumemiTraining/ForecastViewModel.swift Outdated Show resolved Hide resolved
YumemiTraining/ForecastView.swift Outdated Show resolved Hide resolved
YumemiTraining/ForecastView.swift Show resolved Hide resolved
@kantacky kantacky requested a review from ykws February 22, 2024 01:18
Copy link

@novr novr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[must]

  • Session 2: API #2 がsession/1向けにマージされていて、mainにマージされてない影響で、宛先がsession/2のままになっています

YumemiTraining/ForecastViewModel.swift Outdated Show resolved Hide resolved
@kantacky kantacky deleted the branch main February 22, 2024 02:21
@kantacky kantacky closed this Feb 22, 2024
@kantacky kantacky reopened this Feb 22, 2024
@kantacky kantacky changed the base branch from session/2 to main February 22, 2024 02:23
@kantacky kantacky merged commit 8f50e0d into main Feb 22, 2024
@kantacky kantacky deleted the session/3 branch February 22, 2024 09:20
@kantacky kantacky mentioned this pull request Feb 22, 2024
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants