-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Session 2: API #2
Conversation
mainに対してのPRではなく、Session1のブランチに対してマージするPRにしてみましょうか🤔 現状のPRは %%{init: { 'gitGraph': { 'showCommitLabel': false } } }%%
gitGraph
commit
branch session1
commit
commit
branch session2
commit
commit
checkout main
merge session2
↑のように、 %%{init: { 'gitGraph': { 'showCommitLabel': false }} }%%
gitGraph
commit
branch session1
commit
commit
branch session2
commit
commit
checkout session1
merge session2
こうなって、 また、この設定にすると、Session1がマージされた時に自動的にこのPRがmainに向くようになります。 |
@kiy00
なるほど!これなら確かに、その方がいいですね! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
session1 の Git の履歴が繋がっていないようなので rebase か merge が必要です
https://github.com/yumemi-training/ios-training-oikawa/network
import Foundation | ||
import YumemiWeather | ||
|
||
@MainActor |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
メインスレッドから利用されるので明示したい意図がありました!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
この処理をメインスレッドで利用したい動機は何になりますか?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Published
プロパティがメインスレッドでのみ変更されるようにしたいからです
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
#7 で大きくViewModelを更新しました。
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
スレッドを意識しているのは Good です!
質問の意図としては、今の実装だとバックグラウンドで処理されないのでそこを認識した上なのか気になっての質問でした。
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
.resizable() | ||
.foregroundStyle(.blue) | ||
} | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Button { | ||
// TODO: Reload Action | ||
// Reload Action |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
weatherCondition.image | ||
.scaledToFit() | ||
} else { | ||
Color.gray |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Session 2: API
Updates