-
Notifications
You must be signed in to change notification settings - Fork 89
clippy: fix multiple issues #293
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
That's ... a lot of CI failures O_O |
Remaining clippy failures appear to be regressions introduced in e9ebff3 (#289), where the existing CI failures stopped
These are both used in a test. |
This was referenced Mar 29, 2023
There ended up being more clippy failures than just that, but I believe this is all in order now. |
Firstyear
approved these changes
Mar 30, 2023
2 tasks
kikuomax
pushed a commit
to codemonger-io/webauthn-rs
that referenced
this pull request
Nov 24, 2024
* clippy: fix multiple derivable_impls issues * Fix CI failure in clippy check (from kanidm#294) * Remove expect() calls from test_webauthnbuilder_chrome_url * fix-up more clippy errors and warnings from new library versions * another attempt at fixing bardecoder/image dependencies --------- Co-authored-by: Jeeyong Um <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes multiple clippy failures in CI:
derivable_impls
for manyDefault
implementations (added in new clippy)expect_used
regressions missed in making a basic test for a webauthn object from a chrome extension #289image
library versions frombardecoder
wrong_self_convention
inEid::to_bytes()
bool_assert_comparison
innfc/atr.rs
testsbox_default
in multiple places