-
Notifications
You must be signed in to change notification settings - Fork 84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow overriding tunnel server protocol/domain for caBLE #295
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
micolous
force-pushed
the
cable-localhost-tunnel
branch
3 times, most recently
from
March 29, 2023 23:54
f3fa8df
to
85e1b8e
Compare
micolous
added
enhancement
New feature or request
cable
Issues relating to caBLE (Cloud-assisted Bluetooth Low Energy authenticators)
labels
Mar 29, 2023
This was referenced Mar 29, 2023
Merged
micolous
force-pushed
the
cable-localhost-tunnel
branch
2 times, most recently
from
March 30, 2023 06:20
d78132d
to
18cde7e
Compare
9 tasks
Firstyear
previously approved these changes
Apr 11, 2023
micolous
changed the title
caBLE localhost tunnel
Allow overriding tunnel server protocol/domain for caBLE
Apr 12, 2023
micolous
force-pushed
the
cable-localhost-tunnel
branch
from
April 13, 2023 00:54
4196ab1
to
039ecbf
Compare
This makes the library connect to a tunnel server running at `ws://localhost:8080`, rather than the proper tunnel server URL.
micolous
force-pushed
the
cable-localhost-tunnel
branch
from
April 13, 2023 03:59
039ecbf
to
b91d69a
Compare
Firstyear
approved these changes
Apr 16, 2023
kikuomax
pushed a commit
to codemonger-io/webauthn-rs
that referenced
this pull request
Nov 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
cable
Issues relating to caBLE (Cloud-assisted Bluetooth Low Energy authenticators)
enhancement
New feature or request
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a
cable-override-tunnel
feature.This allows the library to override which caBLE tunnel server protocol and domain it connects to, rather than the actual tunnel server. This is useful for testing #291 (caBLE tunnel server implementation), so one can run a tunnel server locally without needing to set up DNS and certificates.
Example
To act as an initiator overriding the tunnel server to be at
ws://localhost:8080
:To act as an authenticator in the same way:
cargo run \ --example cable_tunnel \ --features cable,cable-override-tunnel \ -- \ --serial-port /dev/tty.usbmodem \ --softtoken-path /tmp/softtoken.dat \ --qr-image ~/Desktop/screenshot.png \ --tunnel-uri ws://localhost:8080
Changes
Related fixing (which blocked this change):
doctest
for features that are enabledPublic API changes:
share_cable_authenticator()
's parameters changed:options: ShareCableAuthenticatorOptions
parametertunnel_server_id
argument moved toShareCableAuthenticatorOptions
close_after_one_command
argument inverted tostay_open_after_one_command
, and moved toShareCableAuthenticatorOptions
tunnel_uri
field toShareCableAuthenticatorOptions
Added
connect_cable_authenticator_with_tunnel_uri
method for new feature.This will probably be changed to use a
ConnectCableAuthenticatorOptions
struct likeShareCableAuthenticatorOptions
once there's something else to put in there.Internal API changes:
Eid::get_domain
replaced withEid::get_domain_builder
Eid::get_connect_uri
now (internally) publicEid::build_connect_uri
(internally public)Discovery::build_new_tunnel_uri
(internally public)Discovery::get_connect_uri
removed (useEid::get_connect_uri
instead)uri
parameter toTunnel::connect_authenticator