Do not show usage error for --all flag #960
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When --all flag is set for the `repo delete` command, and there are no repositories to delete, do not shoow usage error.
demusdev
requested review from
sergiimk,
zaychenko-sergei,
s373r and
rmn-boiko
s373r
requested changes
Nov 14, 2024
Comment on lines
+49
to
+54
| if self.names.is_empty() && !self.all { | ||
| return Err(CLIError::usage_error( | ||
| "Specify a repository or use --all flag", | ||
| )); | ||
| } | ||
|
|
There was a problem hiding this comment.
Please use (override) Command::validate_args() for this check
There was a problem hiding this comment.
Also, I think we should work through all the variations
- no names & no
--all - no names &
--all - some names & no
--all - some names &
--all
I think some of these options are redundant and an error message should be provided for them
There was a problem hiding this comment.
Optional: add E2E tests -- Here it would be great to check our errors (output messages)
PS. I'd like to help make these, if you decide to make them, let me know and I'll advise on the best way to approach it
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When --all flag is set for the
repo deletecommand, and there are no repositories to delete, do not shoow usage error.Before
After
Checklist before requesting a review