DatasetOwnershipService: moved to the kamu-dataset area & implemented via DatasetEntryServiceImpl
#1004
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
s373r
force-pushed
the
chore/replace-DatasetOwnershipService-with-DatasetEntryService
branch
from
5574144 to
371bbc6
Compare
s373r
commented
Dec 20, 2024
Comment on lines
+344
to
+345
| || async { Ok(Arc::new(owner_id)) }, | ||
| move |owner_id, pagination| async move { |
There was a problem hiding this comment.
|| async { ... },
move |...| async move {
...
}Offtop: ah, the magical Rust
| }), | ||
| )), | ||
| }); | ||
| break; |
There was a problem hiding this comment.
A soul cry: this break left behind cost me almost 6 hours of debugging...
| @@ -1,414 +0,0 @@ | |||
| // Copyright Kamu Data, Inc. and contributors. All rights reserved. | |||
There was a problem hiding this comment.
Note for readers: duplicate file -- looks like a sad artifact of the previous my big merge.
s373r
deleted the
chore/replace-DatasetOwnershipService-with-DatasetEntryService
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
DatasetOwnershipService: moved to thekamu-datasetarea & implemented viaDatasetEntryServiceImpl