Fix minimum and maximum on nightly
#211
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The special implementation of minimum and maximum was removed in JuliaLang/julia#58267. This means we no longer need the workarounds for versions after this.
kalmarek
approved these changes
May 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the issues mentioned in #209. I found the right
VERSIONfor the PR introducing the change as devmotion taught us in #187. That that PR literally just removes all the special case code forminimumandmaximum, so it should now fall back to the defaultmapreducewithminormaxand then everything works directly as is should forArb.This is built on top of #210 so needs to be rebased once that is merged.