-
Notifications
You must be signed in to change notification settings - Fork 8
Implement rounding related methods #207
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
It seems like there is some work with getting the ambiguity tests to pass as well... |
3d3668f to
cd6ea60
Compare
|
I finally got around to finishing this. I simplified some of the implementations and added tests for everything. I also added a test to make sure that When implementing the tests for Some of the tests are however failing on Julia v1.6. It seems like some of the handling of rounding has been added in later version, and hence are not supported on 1.6. For example trunc(::Type{T}, x) where T = round(T, x, RoundToZero)
floor(::Type{T}, x) where T = round(T, x, RoundDown)
ceil(::Type{T}, x) where T = round(T, x, RoundUp)also seem to not exist in 1.6, leading to |
|
@Joel-Dahne Thanks for all of those changes and staying up to date with julia-nightly ;) |
|
@Joel-Dahne minor release? |
|
I'm currently looking at making |
This implements
roundforArf,Acf,ArbandAcbas well as conversion to general integer types (not onlyIntandBigInt). It also implementsdivforArb. In theory one could implementdivforArf, but getting that to be correctly rounded (which thedivfunction does specify) seems like it could be a little bit of work and I therefore left it out.The motivation for this is discussed in #206.
There is still some work to be done, for example there are currently not any tests...